8000 Surface server name process tag for tomcat by amarziali · Pull Request #8894 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]

Skip to content

Surface server name process tag for tomcat #8894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Surface server.name for tomcat being the current engine name. This is obtained thanks to a dedicated instrumentation.
Also surface server.type from various application servers

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner May 28, 2025 07:28
@amarziali amarziali added the comp: core Tracer core label May 28, 2025
@amarziali amarziali requested a review from a team as a code owner May 28, 2025 07:28
@amarziali amarziali requested a review from ygree May 28, 2025 07:28
@amarziali amarziali force-pushed the andrea.marziali/tomcat-processtags branch from 3170039 to 2a759f7 Compare May 28, 2025 07:39
@pr-commenter
Copy link
pr-commenter bot commented May 28, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/tomcat-processtags
git_commit_date 1746789389 1748439993
git_commit_sha ad6d5fe 4b1c0f9
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~4b1c0f97c1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1748442549 1748442549
ci_job_id 957609945 957609945
ci_pipeline_id 66317877 66317877
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tocws4ec-project-304-concurrent-0-kjikah4d 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tocws4ec-project-304-concurrent-0-kjikah4d 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 3 performance regressions! Performance is the same for 54 metrics, 13 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:tracing:Remote Config worse
[+15.370µs; +67.915µs] or [+2.201%; +9.727%]
739.837µs 698.194µs
scenario:startup:petclinic:profiling:GlobalTracer better
[-19.054ms; -14.991ms] or [-5.054%; -3.976%]
359.991ms 377.013ms
scenario:startup:petclinic:profiling:AppSec worse
[+5.605ms; +8.604ms] or [+10.288%; +15.793%]
61.584ms 54.479ms
scenario:startup:petclinic:tracing:Remote Config worse
[+21.290µs; +87.385µs] or [+3.051%; +12.523%]
752.137µs 697.799µs
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017807
Total [baseline] (10.445 s) : 0, 10445377
Agent [candidate] (1.021 s) : 0, 1020678
Total [candidate] (10.457 s) : 0, 10456707
section appsec
Agent [baseline] (1.163 s) : 0, 1162608
Total [baseline] (10.681 s) : 0, 10681399
Agent [candidate] (1.165 s) : 0, 1165226
Total [candidate] (10.739 s) : 0, 10738665
section iast
Agent [baseline] (1.148 s) : 0, 1148280
Total [baseline] (10.901 s) : 0, 10901179
Agent [candidate] (1.155 s) : 0, 1154919
Total [candidate] (10.839 s) : 0, 10839312
section profiling
Agent [baseline] (1.277 s) : 0, 1276730
Total [baseline] (10.945 s) : 0, 10945088
Agent [candidate] (1.265 s) : 0, 1265425
Total [candidate] (10.855 s) : 0, 10855469
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.018 s -
Agent appsec 1.163 s 144.801 ms (14.2%)
Agent iast 1.148 s 130.473 ms (12.8%)
Agent profiling 1.277 s 258.923 ms (25.4%)
Total tracing 10.445 s -
Total appsec 10.681 s 236.022 ms (2.3%)
Total iast 10.901 s 455.802 ms (4.4%)
Total profiling 10.945 s 499.71 ms (4.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent appsec 1.165 s 144.547 ms (14.2%)
Agent iast 1.155 s 134.241 ms (13.2%)
Agent profiling 1.265 s 244.747 ms (24.0%)
Total tracing 10.457 s -
Total appsec 10.739 s 281.958 ms (2.7%)
Total iast 10.839 s 382.605 ms (3.7%)
Total profiling 10.855 s 398.762 ms (3.8%)
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.756 ms) : 0, 682756
BytebuddyAgent [candidate] (684.127 ms) : 0, 684127
GlobalTracer [baseline] (239.62 ms) : 0, 239620
GlobalTracer [candidate] (240.987 ms) : 0, 240987
AppSec [baseline] (54.48 ms) : 0, 54480
AppSec [candidate] (55.982 ms) : 0, 55982
Debugger [baseline] (8.477 ms) : 0, 8477
Debugger [candidate] (6.974 ms) : 0, 6974
Remote Config [baseline] (697.799 µs) : 0, 698
Remote Config [candidate] (752.137 µs) : 0, 752
Telemetry [baseline] (8.336 ms) : 0, 8336
Telemetry [candidate] (8.261 ms) : 0, 8261
section appsec
BytebuddyAgent [baseline] (701.496 ms) : 0, 701496
BytebuddyAgent [candidate] (701.885 ms) : 0, 701885
GlobalTracer [baseline] (236.68 ms) : 0, 236680
GlobalTracer [candidate] (238.484 ms) : 0, 238484
AppSec [baseline] (176.061 ms) : 0, 176061
AppSec [candidate] (176.181 ms) : 0, 176181
Debugger [baseline] (5.906 ms) : 0, 5906
Debugger [candidate] (5.976 ms) : 0, 5976
Remote Config [baseline] (626.003 µs) : 0, 626
Remote Config [candidate] (654.757 µs) : 0, 655
Telemetry [baseline] (7.362 ms) : 0, 7362
Telemetry [candidate] (7.724 ms) : 0, 7724
IAST [baseline] (21.957 ms) : 0, 21957
IAST [candidate] (21.668 ms) : 0, 21668
section iast
BytebuddyAgent [baseline] (801.875 ms) : 0, 801875
BytebuddyAgent [candidate] (807.805 ms) : 0, 807805
GlobalTracer [baseline] (229.99 ms) : 0, 229990
GlobalTracer [candidate] (230.89 ms) : 0, 230890
AppSec [baseline] (50.342 ms) : 0, 50342
AppSec [candidate] (49.301 ms) : 0, 49301
Debugger [baseline] (5.898 ms) : 0, 5898
Debugger [candidate] (5.818 ms) : 0, 5818
Remote Config [baseline] (595.872 µs) : 0, 596
Remote Config [candidate] (573.31 µs) : 0, 573
Telemetry [baseline] (7.881 ms) : 0, 7881
Telemetry [candidate] (7.88 ms) : 0, 7880
IAST [baseline] (27.452 ms) : 0, 27452
IAST [candidate] (29.049 ms) : 0, 29049
section profiling
BytebuddyAgent [baseline] (671.432 ms) : 0, 671432
BytebuddyAgent [candidate] (673.861 ms) : 0, 673861
GlobalTracer [baseline] (377.013 ms) : 0, 377013
GlobalTracer [candidate] (359.991 ms) : 0, 359991
AppSec [baseline] (54.479 ms) : 0, 54479
AppSec [candidate] (61.584 ms) : 0, 61584
Debugger [baseline] (6.103 ms) : 0, 6103
Debugger [candidate] (6.153 ms) : 0, 6153
Remote Config [baseline] (646.066 µs) : 0, 646
Remote Config [candidate] (646.149 µs) : 0, 646
Telemetry [baseline] (7.993 ms) : 0, 7993
Telemetry [candidate] (8.256 ms) : 0, 8256
ProfilingAgent [baseline] (108.706 ms) : 0, 108706
ProfilingAgent [candidate] (103.858 ms) : 0, 103858
Profiling [base
8000
line] (108.731 ms) : 0, 108731
Profiling [candidate] (103.882 ms) : 0, 103882
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019189
Total [baseline] (8.674 s) : 0, 8674466
Agent [candidate] (1.024 s) : 0, 1024213
Total [candidate] (8.675 s) : 0, 8674563
section iast
Agent [baseline] (1.145 s) : 0, 1144597
Total [baseline] (9.261 s) : 0, 9261003
Agent [candidate] (1.15 s) : 0, 1149661
Total [candidate] (9.23 s) : 0, 9229515
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.151 s) : 0, 1150917
Total [baseline] (9.215 s) : 0, 9215355
Agent [candidate] (1.155 s) : 0, 1155431
Total [candidate] (9.185 s) : 0, 9184950
section iast_TELEMETRY_OFF
Agent [baseline] (1.148 s) : 0, 1148480
Total [baseline] (9.224 s) : 0, 9224300
Agent [candidate] (1.154 s) : 0, 1154433
Total [candidate] (9.242 s) : 0, 9241835
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent iast 1.145 s 125.407 ms (12.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.151 s 131.728 ms (12.9%)
Agent iast_TELEMETRY_OFF 1.148 s 129.291 ms (12.7%)
Total tracing 8.674 s -
Total iast 9.261 s 586.537 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.215 s 540.889 ms (6.2%)
Total iast_TELEMETRY_OFF 9.224 s 549.834 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent iast 1.15 s 125.448 ms (12.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.155 s 131.218 ms (12.8%)
Agent iast_TELEMETRY_OFF 1.154 s 130.22 ms (12.7%)
Total tracing 8.675 s -
Total iast 9.23 s 554.951 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.185 s 510.387 ms (5.9%)
Total iast_TELEMETRY_OFF 9.242 s 567.272 ms (6.5%)
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.07 ms) : 0, 682070
BytebuddyAgent [candidate] (683.285 ms) : 0, 683285
GlobalTracer [baseline] (239.714 ms) : 0, 239714
GlobalTracer [candidate] (241.469 ms) : 0, 241469
AppSec [baseline] (54.248 ms) : 0, 54248
AppSec [candidate] (56.251 ms) : 0, 56251
Debugger [baseline] (9.105 ms) : 0, 9105
Debugger [candidate] (9.39 ms) : 0, 9390
Remote Config [baseline] (698.194 µs) : 0, 698
Remote Config [candidate] (739.837 µs) : 0, 740
Telemetry [baseline] (9.852 ms) : 0, 9852
Telemetry [candidate] (8.883 ms) : 0, 8883
section iast
BytebuddyAgent [baseline] (798.944 ms) : 0, 798944
BytebuddyAgent [candidate] (802.932 ms) : 0, 802932
GlobalTracer [baseline] (229.55 ms) : 0, 229550
GlobalTracer [candidate] (230.68 ms) : 0, 230680
AppSec [baseline] (50.08 ms) : 0, 50080
AppSec [candidate] (47.678 ms) : 0, 47678
Debugger [baseline] (5.84 ms) : 0, 5840
Debugger [candidate] (5.895 ms) : 0, 5895
Remote Config [baseline] (588.044 µs) : 0, 588
Remote Config [candidate] (590.326 µs) : 0, 590
Telemetry [baseline] (7.809 ms) : 0, 7809
Telemetry [candidate] (7.824 ms) : 0, 7824
IAST [baseline] (28.395 ms) : 0, 28395
IAST [candidate] (30.599 ms) : 0, 30599
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (801.643 ms) : 0, 801643
BytebuddyAgent [candidate] (806.507 ms) : 0, 806507
GlobalTracer [baseline] (231.854 ms) : 0, 231854
GlobalTracer [candidate] (231.917 ms) : 0, 231917
AppSec [baseline] (50.726 ms) : 0, 50726
AppSec [candidate] (47.767 ms) : 0, 47767
Debugger [baseline] (5.957 ms) : 0, 5957
Debugger [candidate] (5.87 ms) : 0, 5870
Remote Config [baseline] (594.592 µs) : 0, 595
Remote Config [candidate] (584.337 µs) : 0, 584
Telemetry [baseline] (7.902 ms) : 0, 7902
Telemetry [candidate] (7.939 ms) : 0, 7939
IAST [baseline] (28.697 ms) : 0, 28697
IAST [candidate] (31.301 ms) : 0, 31301
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (801.919 ms) : 0, 801919
BytebuddyAgent [candidate] (805.832 ms) : 0, 805832
GlobalTracer [baseline] (230.909 ms) : 0, 230909
GlobalTracer [candidate] (232.384 ms) : 0, 232384
AppSec [baseline] (53.982 ms) : 0, 53982
AppSec [candidate] (54.101 ms) : 0, 54101
Debugger [baseline] (5.918 ms) : 0, 5918
Debugger [candidate] (5.895 ms) : 0, 5895
Remote Config [baseline] (596.007 µs) : 0, 596
Remote Config [candidate] (586.196 µs) : 0, 586
Telemetry [baseline] (7.715 ms) : 0, 7715
Telemetry [candidate] (7.79 ms) : 0, 7790
IAST [baseline] (23.963 ms) : 0, 23963
IAST [candidate] (22.673 ms) : 0, 22673
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-05-28T14:00:43 2025-05-28T14:08:26
git_branch master andrea.marziali/tomcat-processtags
git_commit_date 1746789389 1748439993
git_commit_sha ad6d5fe 4b1c0f9
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~4b1c0f97c1
start_time 2025-05-28T14:00:28 2025-05-28T14:08:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1748441706 1748441706
ci_job_id 957609946 957609946
ci_pipeline_id 66317877 66317877
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-tocws4ec-project-304-concurrent-1-4q09h8e6 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-tocws4ec-project-304-concurrent-1-4q09h8e6 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.619 µs) : 363, 403
.   : milestone, 383,
iast (524.684 µs) : 501, 548
.   : milestone, 525,
iast_FULL (733.82 µs) : 712, 756
.   : milestone, 734,
iast_GLOBAL (571.37 µs) : 548, 594
.   : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (509.614 µs) : 488, 531
.   : milestone, 510,
iast_INACTIVE (478.705 µs) : 454, 503
.   : milestone, 479,
iast_TELEMETRY_OFF (501.22 µs) : 478, 524
.   : milestone, 501,
tracing (455.285 µs) : 432, 479
.   : milestone, 455,
section candidate
no_agent (376.526 µs) : 357, 396
.   : milestone, 377,
iast (517.04 µs) : 495, 539
.   : milestone, 517,
iast_FULL (749.517 µs) : 726, 773
.   : milestone, 750,
iast_GLOBAL (566.351 µs) : 543, 589
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (527.406 µs) : 506, 549
.   : milestone, 527,
iast_INACTIVE (468.594 µs) : 446, 491
.   : milestone, 469,
iast_TELEMETRY_OFF (500.799 µs) : 478, 524
.   : milestone, 501,
tracing (459.464 µs) : 437, 481
.   : milestone, 459,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.619 µs [362.656 µs, 402.582 µs] -
iast 524.684 µs [500.931 µs, 548.436 µs] 142.065 µs (37.1%)
iast_FULL 733.82 µs [711.965 µs, 755.676 µs] 351.202 µs (91.8%)
iast_GLOBAL 571.37 µs [548.254 µs, 594.485 µs] 188.751 µs (49.3%)
iast_HARDCODED_SECRET_DISABLED 509.614 µs [488.041 µs, 531.187 µs] 126.995 µs (33.2%)
iast_INACTIVE 478.705 µs [453.975 µs, 503.436 µs] 96.087 µs (25.1%)
iast_TELEMETRY_OFF 501.22 µs [478.087 µs, 524.352 µs] 118.601 µs (31.0%)
tracing 455.285 µs [431.869 µs, 478.701 µs] 72.666 µs (19.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.526 µs [357.035 µs, 396.017 µs] -
iast 517.04 µs [495.166 µs, 538.915 µs] 140.514 µs (37.3%)
iast_FULL 749.517 µs [726.006 µs, 773.028 µs] 372.99 µs (99.1%)
iast_GLOBAL 566.351 µs [543.226 µs, 589.476 µs] 189.825 µs (50.4%)
iast_HARDCODED_SECRET_DISABLED 527.406 µs [505.743 µs, 549.07 µs] 150.88 µs (40.1%)
iast_INACTIVE 468.594 µs [445.807 µs, 491.38 µs] 92.067 µs (24.5%)
iast_TELEMETRY_OFF 500.799 µs [477.618 µs, 523.98 µs] 124.273 µs (33.0%)
tracing 459.464 µs [437.433 µs, 481.495 µs] 82.938 µs (22.0%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.359 ms) : 1340, 1379
.   : milestone, 1359,
appsec (1.74 ms) : 1716, 1764
.   : milestone, 1740,
appsec_no_iast (1.73 ms) : 1706, 1754
.   : milestone, 1730,
code_origins (1.673 ms) : 1647, 1700
.   : milestone, 1673,
iast (1.495 ms) : 1471, 1519
.   : milestone, 1495,
profiling (1.515 ms) : 1492, 1537
.   : milestone, 1515,
tracing (1.499 ms) : 1474, 1524
.   : milestone, 1499,
section candidate
no_agent (1.355 ms) : 1336, 1375
.   : milestone, 1355,
appsec (1.73 ms) : 1707, 1754
.   : milestone, 1730,
appsec_no_iast (1.732 ms) : 1709, 1756
.   : milestone, 1732,
code_origins (1.664 ms) : 1636, 1691
.   : milestone, 1664,
iast (1.51 ms) : 1486, 1534
.   : milestone, 1510,
profiling (1.564 ms) : 1539, 1588
.   : milestone, 1564,
tracing (1.499 ms) : 1476, 1523
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.359 ms [1.34 ms, 1.379 ms] -
appsec 1.74 ms [1.716 ms, 1.764 ms] 380.566 µs (28.0%)
appsec_no_iast 1.73 ms [1.706 ms, 1.754 ms] 370.489 µs (27.3%)
code_origins 1.673 ms [1.647 ms, 1.7 ms] 314.148 µs (23.1%)
iast 1.495 ms [1.471 ms, 1.519 ms] 135.64 µs (10.0%)
profiling 1.515 ms [1.492 ms, 1.537 ms] 155.313 µs (11.4%)
tracing 1.499 ms [1.474 ms, 1.524 ms] 1 10000 39.743 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.336 ms, 1.375 ms] -
appsec 1.73 ms [1.707 ms, 1.754 ms] 375.043 µs (27.7%)
appsec_no_iast 1.732 ms [1.709 ms, 1.756 ms] 376.943 µs (27.8%)
code_origins 1.664 ms [1.636 ms, 1.691 ms] 308.397 µs (22.8%)
iast 1.51 ms [1.486 ms, 1.534 ms] 154.502 µs (11.4%)
profiling 1.564 ms [1.539 ms, 1.588 ms] 208.266 µs (15.4%)
tracing 1.499 ms [1.476 ms, 1.523 ms] 144.043 µs (10.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/tomcat-processtags
git_commit_date 1746789389 1748439993
git_commit_sha ad6d5fe 4b1c0f9
release_version 1.50.0-SNAPSHOT~ad6d5fef42 1.50.0-SNAPSHOT~4b1c0f97c1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1748442290 1748442290
ci_job_id 957609947 957609947
ci_pipeline_id 66317877 66317877
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-yayxzzxb-project-304-concurrent-0-dvcgmt1m 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-yayxzzxb-project-304-concurrent-0-dvcgmt1m 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.386 ms) : 2338, 2435
.   : milestone, 2386,
iast (2.161 ms) : 2101, 2222
.   : milestone, 2161,
iast_GLOBAL (2.21 ms) : 2149, 2271
.   : milestone, 2210,
profiling (2.036 ms) : 1986, 2086
.   : milestone, 2036,
tracing (2.005 ms) : 1957, 2053
.   : milestone, 2005,
section candidate
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.39 ms) : 2341, 2439
.   : milestone, 2390,
iast (2.179 ms) : 2118, 2240
.   : milestone, 2179,
iast_GLOBAL (2.215 ms) : 2153, 2277
.   : milestone, 2215,
profiling (2.057 ms) : 2006, 2108
.   : milestone, 2057,
tracing (2.001 ms) : 1953, 2049
.   : milestone, 2001,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.386 ms [2.338 ms, 2.435 ms] 918.846 µs (62.6%)
iast 2.161 ms [2.101 ms, 2.222 ms] 693.582 µs (47.3%)
iast_GLOBAL 2.21 ms [2.149 ms, 2.271 ms] 742.343 µs (50.6%)
profiling 2.036 ms [1.986 ms, 2.086 ms] 568.582 µs (38.7%)
tracing 2.005 ms [1.957 ms, 2.053 ms] 537.287 µs (36.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.456 ms, 1.479 ms] -
appsec 2.39 ms [2.341 ms, 2.439 ms] 922.679 µs (62.9%)
iast 2.179 ms [2.118 ms, 2.24 ms] 711.006 µs (48.4%)
iast_GLOBAL 2.215 ms [2.153 ms, 2.277 ms] 747.029 µs (50.9%)
profiling 2.057 ms [2.006 ms, 2.108 ms] 589.475 µs (40.2%)
tracing 2.001 ms [1.953 ms, 2.049 ms] 533.52 µs (36.3%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~4b1c0f97c1, baseline=1.50.0-SNAPSHOT~ad6d5fef42
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
appsec (15.02 s) : 15020000, 15020000
.   : milestone, 15020000,
iast (18.782 s) : 18782000, 18782000
.   : milestone, 18782000,
iast_GLOBAL (17.921 s) : 17921000, 17921000
.   : milestone, 17921000,
profiling (15.586 s) : 15586000, 15586000
.   : milestone, 15586000,
tracing (14.869 s) : 14869000, 14869000
.   : milestone, 14869000,
section candidate
no_agent (15.253 s) : 15253000, 15253000
.   : milestone, 15253000,
appsec (15.085 s) : 15085000, 15085000
.   : milestone, 15085000,
iast (18.725 s) : 18725000, 18725000
.   : milestone, 18725000,
iast_GLOBAL (18.186 s) : 18186000, 18186000
.   : milestone, 18186000,
profiling (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
tracing (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.998 s [14.998 s, 14.998 s] -
appsec 15.02 s [15.02 s, 15.02 s] 22.0 ms (0.1%)
iast 18.782 s [18.782 s, 18.782 s] 3.784 s (25.2%)
iast_GLOBAL 17.921 s [17.921 s, 17.921 s] 2.923 s (19.5%)
profiling 15.586 s [15.586 s, 15.586 s] 588.0 ms (3.9%)
tracing 14.869 s [14.869 s, 14.869 s] -129.0 ms (-0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.253 s [15.253 s, 15.253 s] -
appsec 15.085 s [15.085 s, 15.085 s] -168.0 ms (-1.1%)
iast 18.725 s [18.725 s, 18.725 s] 3.472 s (22.8%)
iast_GLOBAL 18.186 s [18.186 s, 18.186 s] 2.933 s (19.2%)
profiling 15.089 s [15.089 s, 15.089 s] -164.0 ms (-1.1%)
tracing 15.063 s [15.063 s, 15.063 s] -190.0 ms (-1.2%)

@amarziali amarziali force-pushed the andrea.marziali/tomcat-processtags branch from 2a759f7 to 71552fb Compare May 28, 2025 12:13
Base automatically changed from andrea.marziali/complete-process-tags to master May 28, 2025 13:01
@amarziali amarziali force-pushed the andrea.marziali/tomcat-processtags branch from 71552fb to fcebc14 Compare May 28, 2025 13:05
@amarziali amarziali enabled auto-merge (squash) May 28, 2025 13:05
@amarziali amarziali merged commit 97258b1 into master May 28, 2025
522 of 523 checks passed
@amarziali amarziali deleted the andrea.marziali/tomcat-processtags branch May 28, 2025 15:37
@github-actions github-actions bot added this to the 1.50.0 milestone May 28, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jun 20, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`1.49.0` -> `1.50.0` |

---

### Release Notes

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0):
1.50.0

### Deprecation Notice

> \[!NOTE]
> `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in
future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED`
instead.

### Components

#### Application Security Management (WAF)

- 🐛 Add String length truncation limit to ObjectIntrospector and
update truncation metrics
([#&#8203;8825](DataDog/dd-trace-java#8825) -
[@&#8203;jandro996](https://github.com/jandro996))
- 🐛 Adapt standalone ASM to support API Security
([#&#8203;8804](DataDog/dd-trace-java#8804) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Add appsec.waf.input\_truncated metric
([#&#8203;8791](DataDog/dd-trace-java#8791) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Extended appsec request body collection
([#&#8203;8748](DataDog/dd-trace-java#8748) -
[@&#8203;jandro996](https://github.com/jandro996))
- ✨ Extended appsec request/response headers collection
([#&#8203;8724](DataDog/dd-trace-java#8724) -
[@&#8203;jandro996](https://github.com/jandro996))

#### Build & Tooling

- ✨ Add artifacts to public s3 bucket
([#&#8203;8947](DataDog/dd-trace-java#8947) -
[@&#8203;randomanderson](https://github.com/randomanderson))

#### Continuous Integration Visibility

- ✨ Improve PR information building
([#&#8203;8908](DataDog/dd-trace-java#8908) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Truncate span stack traces when Test Optimization is
enabled
([#&#8203;8903](DataDog/dd-trace-java#8903) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🐛 Ensure auto-detected service name is the same for every process
in the same build
([#&#8203;8902](DataDog/dd-trace-java#8902) -
[@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog))
- 🐛 Use tag as fallback in api requests if no branch is available
([#&#8203;8876](DataDog/dd-trace-java#8876) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Add support for JUnit 5.13-RC1
([#&#8203;8865](DataDog/dd-trace-java#8865),
[#&#8203;8871](DataDog/dd-trace-java#8871) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Implement attempt to fix v3 and v4 and bump capability
version
([#&#8203;8824](DataDog/dd-trace-java#8824) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🧹 Align retry logic for all test framework instrumentations
([#&#8203;8803](DataDog/dd-trace-java#8803) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- 🐛 Always build ci workspace without trailing separator
([#&#8203;8788](DataDog/dd-trace-java#8788) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))
- ✨ Add commit discrepancies telemetry when building repository
git information
([#&#8203;8763](DataDog/dd-trace-java#8763) -
[@&#8203;daniel-mohedano](https://github.com/daniel-mohedano))

#### Data Streams Monitoring

- 💡 Surface process tags in dsm payloads and use them for base hash
calculation
([#&#8203;8836](DataDog/dd-trace-java#8836) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Dynamic Instrumentation

- ✨ Optimized allocations for collection filter functions
([#&#8203;8896](DataDog/dd-trace-java#8896) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Fix SymDB upload size check
([#&#8203;8887](DataDog/dd-trace-java#8887) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Add support for Set in filter function
([#&#8203;8873](DataDog/dd-trace-java#8873) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Add support for isDefined in log template
([#&#8203;8859](DataDog/dd-trace-java#8859) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Fix Max captured frames for Exception Replay
([#&#8203;8856](DataDog/dd-trace-java#8856) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 🐛 Remove static inherited fields collection
([#&#8203;8832](DataDog/dd-trace-java#8832) -
[@&#8203;jpbempel](https://github.com/jpbempel))
- 💡 Add process tags to dynamic instrumentation intake payload
([#&#8203;8779](DataDog/dd-trace-java#8779) -
[@&#8203;amarziali](https://github.com/amarziali))

#### GraalVM native-image

- ✨ Add support for GraalVM Native GC metrics
([#&#8203;8913](DataDog/dd-trace-java#8913) -
[@&#8203;ygree](https://github.com/ygree))
- ✨ Add JMXFetch support for GraalVM Native
([#&#8203;8569](DataDog/dd-trace-java#8569) -
[@&#8203;ygree](https://github.com/ygree))

#### JMX fetch

- ✨ Add support for GraalVM Native GC metrics
([#&#8203;8913](DataDog/dd-trace-java#8913) -
[@&#8203;ygree](https://github.com/ygree))

#### Library Injection

- ✨ Deny oracle db jvm based tools
([#&#8203;8909](DataDog/dd-trace-java#8909) -
[@&#8203;bric3](https://github.com/bric3))

#### OpenTracing

- 🐛 Fix OT packaging for exception replay
([#&#8203;8912](DataDog/dd-trace-java#8912) -
[@&#8203;jpbempel](https://github.com/jpbempel))

#### Profiling

- ✨ Bump ddprof to 1.27.0
([#&#8203;8893](DataDog/dd-trace-java#8893) -
[@&#8203;jbachorik](https://github.com/jbachorik))
- Properly handle the adaptive sampling interval overflow by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#213
- Fix [#&#8203;200](DataDog/dd-trace-java#200)
Crash related to aligned\_alloc and free in context by
[@&#8203;yanglong1010](https://github.com/yanglong1010) in
DataDog/java-profiler#208
- Explicitly initialize empty context page by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#210
- Re-connect crash recursion protection with VM stackwalker by
[@&#8203;jbachorik](https://github.com/jbachorik) in
DataDog/java-profiler#214
- ✨ Enable ZSTD compression for profiling
([#&#8203;8862](DataDog/dd-trace-java#8862) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- ✨ Extend JPS re-implementation to J9 family
([#&#8203;8813](DataDog/dd-trace-java#8813) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- 💡 Collect process tags for profiling upload requests
([#&#8203;8780](DataDog/dd-trace-java#8780) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Telemetry

- 💡 Surface process tags on telemetry payloads
([#&#8203;8837](DataDog/dd-trace-java#8837) -
[@&#8203;amarziali](https://github.com/amarziali))

#### Trace context propagation

- ✨ Migrating all HttpClient Instrumentations to Inject Full
Context
([#&#8203;8826](DataDog/dd-trace-java#8826) -
[@&#8203;mhlidd](https://github.com/mhlidd))
- ✨ Migrating all HttpServer Instrumentations to Extract full
Context
([#&#8203;8820](DataDog/dd-trace-java#8820) -
[@&#8203;mhlidd](https://github.com/mhlidd))
- ✨ Add context API support OTel propagators
([#&#8203;8770](DataDog/dd-trace-java#8770) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Tracer core

- ✨⚡ Skip JAXB generated classes classloader
([#&#8203;9003](DataDog/dd-trace-java#9003) -
[@&#8203;bric3](https://github.com/bric3))
- ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for
runtime id generation
([#&#8203;8981](DataDog/dd-trace-java#8981) -
[@&#8203;amarziali](https://github.com/amarziali))
- 🐛 Use resolved address for peer.hostname when available without
hitting the cache
([#&#8203;8915](Data
8000
Dog/dd-trace-java#8915) -
[@&#8203;amarziali](https://github.com/amarziali))
- 💡 Surface server name process tag for tomcat
([#&#8203;8894](DataDog/dd-trace-java#8894) -
[@&#8203;amarziali](https://github.com/amarziali))
- 💡 Surface websphere cell and server name on process tags
([#&#8203;8880](DataDog/dd-trace-java#8880) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Added special lightweight pre-main class that skips
installation on incompatible JVMs.
([#&#8203;8855](DataDog/dd-trace-java#8855) -
[@&#8203;AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD))
- 💡 Add entrypoint type to process tags
([#&#8203;8839](DataDog/dd-trace-java#8839) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Extend JPS re-implementation to J9 family
([#&#8203;8813](DataDog/dd-trace-java#8813) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- ✨ Notify listeners when the scope top changes after switching
scope stacks
([#&#8203;8797](DataDog/dd-trace-java#8797) -
[@&#8203;mcculls](https://github.com/mcculls))
- ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable
([#&#8203;8792](DataDog/dd-trace-java#8792) -
[@&#8203;MattAlp](https://github.com/MattAlp))
- 🐛 Turn JDK socket support on by default
([#&#8203;8752](DataDog/dd-trace-java#8752) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))
- ✨ Simplify context propagation
([#&#8203;8719](DataDog/dd-trace-java#8719) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))
- ✨ Add JSON parsing support
([#&#8203;8579](DataDog/dd-trace-java#8579) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Tracer internal logging

- ✨ Fix printing format of span identifiers
([#&#8203;8897](DataDog/dd-trace-java#8897) -
[@&#8203;vandonr](https://github.com/vandonr))

#### Tracer public API

- 💡 Track the source of installation
([#&#8203;8956](DataDog/dd-trace-java#8956) -
[@&#8203;mabdinur](https://github.com/mabdinur))
- ✨ Enforce size limit on application\_monitoring.yaml files
([#&#8203;8789](DataDog/dd-trace-java#8789) -
[@&#8203;mtoffl01](https://github.com/mtoffl01))
- ✨ Enabling baggage cache to support limits and non-ascii
characters
([#&#8203;8713](DataDog/dd-trace-java#8713) -
[@&#8203;mhlidd](https://github.com/mhlidd))

### Instrumentations

#### AWS Lambda instrumentation

- ✨ Pass Lambda Request ID to Extension
([#&#8203;8814](DataDog/dd-trace-java#8814) -
[@&#8203;nhulston](https://github.com/nhulston))

#### Core Java language instrumentation

- ✨ Ensure ClassloadingInstrumentation is always applied even
with `DD_TRACE_ENABLED=false`
([#&#8203;8863](DataDog/dd-trace-java#8863) -
[@&#8203;mcculls](https://github.com/mcculls))

#### Eclipse Vert.x instrumentation

- 🐛 Do not override route with / in vertx instrumentation
([#&#8203;8881](DataDog/dd-trace-java#8881) -
[@&#8203;vandonr](https://github.com/vandonr))

#### IBM Liberty

- 🐛 Fix error mark on http status for IBM liberty
([#&#8203;8822](DataDog/dd-trace-java#8822) -
[@&#8203;amarziali](https://github.com/amarziali))

#### JDBC instrumentation

- 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there
is a pg plan hint
([#&#8203;8864](DataDog/dd-trace-java#8864) -
[@&#8203;edengorevoy](https://github.com/edengorevoy))

#### JMS instrumentation

- ✨ Add jms as an extra integration name where there is JMS
involved
([#&#8203;8933](DataDog/dd-trace-java#8933) -
[@&#8203;vandonr](https://github.com/vandonr))

#### Kotlin instrumentation

- ✨ Enable kotlin\_coroutine integration by default
([#&#8203;8848](DataDog/dd-trace-java#8848) -
[@&#8203;mcculls](https://github.com/mcculls))
- 🧹 Rework Kotlin coroutines instrumentation around coroutine
context
([#&#8203;8774](DataDog/dd-trace-java#8774) -
[@&#8203;mcculls](https://github.com/mcculls))

#### OpenTelemetry instrumentation

- 🐛 Support WithSpan inheritContext attribute
([#&#8203;8858](DataDog/dd-trace-java#8858) -
[@&#8203;amarziali](https://github.com/amarziali))
- ✨ Add context API support OTel propagators
([#&#8203;8770](DataDog/dd-trace-java#8770) -
[@&#8203;PerfectSlayer](https://github.com/PerfectSlayer))

#### Play Framework instrumentation

- 🐛 Fix the Play Framework's span resource name priority so that the
client JAX-RS 404 cannot override it
([#&#8203;8591](DataDog/dd-trace-java#8591) -
[@&#8203;ygree](https://github.com/ygree))

#### Quarkus Instrumentation

- 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies
([#&#8203;8891](DataDog/dd-trace-java#8891) -
[@&#8203;amarziali](https://github.com/amarziali))

#### ServiceTalk

- ✨ Improve ServiceTalk Captured Context API Instrumentation
for v0.42.56+
([#&#8203;8821](DataDog/dd-trace-java#8821) -
[@&#8203;ygree](https://github.com/ygree))

#### Spring instrumentation

- ✨ Supporting Baggage for Instrumentations used in Weblog
Tests
([#&#8203;8773](DataDog/dd-trace-java#8773) -
[@&#8203;mhlidd](https://github.com/mhlidd))

#### WebSocket Instrumentation

- 💡 Trace websocket for spring webflux reactive handlers
([#&#8203;8831](DataDog/dd-trace-java#8831) -
[@&#8203;amarziali](https://github.com/amarziali))
- 💡:test\_tube: WebSocket support for Netty
([#&#8203;8632](DataDog/dd-trace-java#8632) -
[@&#8203;ValentinZakharov](https://github.com/ValentinZakharov))

#### Zio Instrumentation

- 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation
of continuation
([#&#8203;8798](DataDog/dd-trace-java#8798) -
[@&#8203;mcculls](https://github.com/mcculls))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0