8000 Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and `/features` Tests by aaronskiba · Pull Request #3491 · DMPRoadmap/roadmap · GitHub
[go: up one dir, main page]
Skip to content

Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and /features Tests #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 24, 2025
Merged

Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and /features Tests #3491

merged 4 commits into from
Mar 24, 2025

Conversation

aaronskiba
Copy link
Contributor
@aaronskiba aaronskiba commented Mar 20, 2025 •
edited
Loading

Fixes # (Only a temporary fix for #3485)

Changes proposed in this PR:

  • Replace image-bundled Chrome version with Chrome version 128
    • This change addresses the breaking changes encountered between Chrome version 134 and our /features tests
    • NOTE: This change should be reverted once are /features tests are working with the latest Chrome version
  • Refactored spec/features/modal_search_spec.rb to allow both tests within the file to share the same modal logic

@aaronskiba
TEMP: Lower Chrome Version for Postgres GH Action
748a94f 
- This change provides a temporary workaround for the following GitHub Issue: #3485
- This commit should be reverted once our tests are able to run successfully with the latest version of Chrome.
@aaronskiba aaronskiba changed the title TEMP: Lower Chrome Version for Postgres GH Action Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and /features Tests Mar 20, 2025
@aaronskiba aaronskiba marked this pull request as ready for review March 20, 2025 19:25
@aaronskiba
Refactor spec/features/modal_search_spec.rb
fb2d871 
This change refactors `spec/features/modal_search_spec.rb` by adding a method which contains the modal logic shared between both of the tests within the file.
@aaronskiba
Refactor to make rubocop happy
383a2f0
@aaronskiba
Update CHANGELOG.md
cd3f480
@aaronskiba aaronskiba force-pushed the aaron/issues/downgrade-chrome branch from 111ad9a to cd3f480 Compare March 20, 2025 21:01
@johnpinto1 johnpinto1 self-requested a review March 24, 2025 09:30
johnpinto1
johnpinto1 approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor
@johnpinto1 johnpinto1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The temporary Chrome downgrade sorts the failing test issues on Github. The refactoring suggested by Rubocop has been done.

@aaronskiba aaronskiba merged commit 6a49bd6 into development Mar 24, 2025
9 checks passed
@aaronskiba aaronskiba deleted the aaron/issues/downgrade-chrome branch March 24, 2025 15:01
@aaronskiba aaronskiba mentioned this pull request Mar 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpinto1 johnpinto1 johnpinto1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronskiba @johnpinto1
0