8000 Clean up NMS_Common to make it compile for all supported versions by DerEchtePilz · Pull Request #641 · CommandAPI/CommandAPI · GitHub
[go: up one dir, main page]
Skip to content

Clean up NMS_Common to make it compile for all supported versions #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 22, 2025
Merged

Clean up NMS_Common to make it compile for all supported versions #641

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
99cf995
Clean up NMS_Common to make it compile for all supported versions
DerEchtePilz Apr 17, 2025
485ba88
Use 1.21.3 dependency
DerEchtePilz Apr 17, 2025
49503a7
Use more GH Actions steps to fail the build when it isn't compatible …
DerEchtePilz Apr 17, 2025
4edc5b6
Use --quiet flag in the script
DerEchtePilz Apr 17, 2025
a29c068
Remove unused method
DerEchtePilz Apr 17, 2025
cd038b4
Remove NMS_CommonWithFunctions_XXX classes
DerEchtePilz Apr 17, 2025
75ad0e1
Make sure specialsource uses the correct version
DerEchtePilz Apr 17, 2025
dc1b999
Move methods out and into NMS_Common when possible
DerEchtePilz Apr 18, 2025
a41e73a
Make compileNMSCommon.sh more compact
DerEchtePilz Apr 18, 2025
6e003bc
There's no need to have this static
DerEchtePilz Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused method
  • Loading branch information
@DerEchtePilz
DerEchtePilz committed Apr 22, 2025
commit a29c068ea4e5a375028aecf5699ba7c791f92568
5 changes: 0 additions & 5 deletions ...t-nms/commandapi-bukkit-n A762 ms-common/src/main/java/dev/jorel/commandapi/nms/NMS_Common.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,10 @@
import net.minecraft.commands.arguments.coordinates.Vec3Argument;
import net.minecraft.commands.arguments.item.FunctionArgument;
import net.minecraft.core.Direction;
import net.minecraft.resources.ResourceLocation;
import net.minecraft.world.phys.Vec2;
import org.bukkit.Axis;
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.NamespacedKey;
import org.bukkit.OfflinePlayer;
import org.bukkit.Sound;
import org.bukkit.command.CommandSender;
Expand All @@ -85,9 +83,6 @@
* versions.
*/
public abstract class NMS_Common extends CommandAPIBukkit<CommandSourceStack> {
private static NamespacedKey fromResourceLocation(ResourceLocation key) {
return NamespacedKey.fromString(key.getNamespace() + ":" + key.getPath());
}

@Override
public final ArgumentType<?> _ArgumentAngle() {
Expand Down
0