8000 Clean up NMS_Common to make it compile for all supported versions by DerEchtePilz · Pull Request #641 · CommandAPI/CommandAPI · GitHub
[go: up one dir, main page]
Skip to content

Clean up NMS_Common to make it compile for all supported versions #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 22, 2025
Merged

Clean up NMS_Common to make it compile for all supported versions #641

merged 10 commits into from
Apr 22, 2025

Conversation

DerEchtePilz
Copy link
Member

No description provided.

@DerEchtePilz DerEchtePilz marked this pull request as draft April 17, 2025 16:05
@DerEchtePilz DerEchtePilz marked this pull request as ready for review April 17, 2025 16:12
willkroboth
willkroboth reviewed Apr 17, 2025
View reviewed changes
Copy link
Collaborator
@willkroboth willkroboth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and looks good to me. Just two comments (ignore the one you already addressed :P).

@DerEchtePilz DerEchtePilz force-pushed the fix/make-nms-common-actually-common branch from 43e2929 to 2262771 Compare April 19, 2025 16:40
@DerEchtePilz DerEchtePilz force-pushed the fix/make-nms-common-actually-common branch from 2262771 to 6e003bc Compare April 22, 2025 12:14
@DerEchtePilz DerEchtePilz merged commit 9fc9081 into dev/dev Apr 22, 2025
4 checks passed
@DerEchtePilz DerEchtePilz deleted the fix/make-nms-common-actually-common branch April 22, 2025 12:29
@DerEchtePilz DerEchtePilz mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkroboth willkroboth willkroboth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@DerEchtePilz @willkroboth
0