8000 Fix ignored invalid field when enum is present by faddiv · Pull Request #8026 · ChilliCream/graphql-platform · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignored invalid field when enum is present #8026

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Fix ignored invalid field when enum is present #8026

merged 5 commits into from
Feb 17, 2025

Conversation

faddiv
Copy link
Contributor
@faddiv faddiv commented Feb 15, 2025

Fixes "Invalid fields in variable ignored when an enum is present"

  • Extends User in VariableCoercionIntegrationTests with an enum field and updates related fields.
  • Adds an integration test to cover the case: Invalid_Field_Provided_When_Enum_Is_Present
  • Adds an integration test to cover invalid enum value: Invalid_Enum_Value_Provided

Closes #8025

@faddiv faddiv changed the title Fix ignored field when enum is present Fix ignored invalid field when enum is present Feb 17, 2025
michaelstaib
michaelstaib requested changes Feb 17, 2025
View reviewed changes
Copy link
Member
@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your fix brings unpredictability into the coercion. I will have a look at it today.

michaelstaib
michaelstaib approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member
@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK ... forget what I said :) I had to get this particular code back on my stack. Thank you for your contribution!

@michaelstaib michaelstaib merged commit 09a7c51 into ChilliCream:main Feb 17, 2025
3 checks passed
michaelstaib added a commit that referenced this pull request Feb 19, 2025
@glen-84 @danielreynolds1
@michaelstaib @m-gasser @faddiv @tobias-tengler
Merged main into mst/readonly-types-abstractions (#8035)
05f7a62 
* [Fusion] Added post-merge validation rule "EmptyMergedInputObjectTypeRule" (#7993)

* [Fusion] Refactored merging to ensure correct type references (#7995)

* Fixed CookieCrumble Package Configurations. (#7998)

* [Fusion] Added merging of implemented interfaces (#7999)

* Added more include overloads. (#8002)

* [Fusion] Used `@fusion__inaccessible` in the execution schema (#8005)

* Added support for LocalDate/LocalDateTime/LocalTime to Strawberry Shake (#8007)

* Request totalCount through ToPageAsync if its requested. (#8011)

* Added QueryContext extension methods for Select and Include. (#8013)

* Switched LangVersion from `preview` to `13.0` (#8014)

* Updated .NET 9 packages (#8012)

* Changed the runtime type for the Date scalar in Strawberry Shake (#8009)

* Added Strawberry Shake runtime type change to migration guide (#8010)

* Migrated to new solution file format. (#8027)

* Combining the CompilationProvider is an anti-pattern, create an IncrementalValueProvider for the assembly name instead. (#8021)

* Fixed ignored invalid field when enum is present (#8026)

* Allow for internal DataLoader modules and groups. (#8028)

* Updated the latest stable version for the docs to v15 (#8018)

* Added documentation directory for Fusion v15 (#8017)

* Added Strawberry Shake migration documents to `docs.json` (#8015)

* [Fusion] Fix explosion of selections (#8030)

---------

Co-authored-by: Daniel Reynolds <55194784+danielreynolds1@users.noreply.github.com>
Co-authored-by: Michael Staib <michael@chillicream.com>
Co-authored-by: Martin Gasser <m-gasser@gmx.net>
Co-authored-by: faddiv <faddiv@gmail.com>
Co-authored-by: Tobias Tengler <45513122+tobias-tengler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
🌶️ hot chocolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid fields in variable ignored when an enum is present.
2 participants
@faddiv @michaelstaib
0