Combining the CompilationProvider is an anti-pattern, create an IncrementalValueProvider for the assembly name instead. #8021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentalValueProvider for the assembly name instead.
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8021 +/- ##
=======================================
Coverage 74.42% 74.42%
=======================================
Files 2902 2902
Lines 152515 152516 +1
Branches 17794 17794
=======================================
+ Hits 113507 113508 +1
- Misses 33100 33101 +1
+ Partials 5908 5907 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hey @m-gasser, thank you for your contribution! |
michaelstaib
added a commit
that referenced
this pull request
Feb 19, 2025
* [Fusion] Added post-merge validation rule "EmptyMergedInputObjectTypeRule" (#7993) * [Fusion] Refactored merging to ensure correct type references (#7995) * Fixed CookieCrumble Package Configurations. (#7998) * [Fusion] Added merging of implemented interfaces (#7999) * Added more include overloads. (#8002) * [Fusion] Used `@fusion__inaccessible` in the execution schema (#8005) * Added support for LocalDate/LocalDateTime/LocalTime to Strawberry Shake (#8007) * Request totalCount through ToPageAsync if its requested. (#8011) * Added QueryContext extension methods for Select and Include. (#8013) * Switched LangVersion from `preview` to `13.0` (#8014) * Updated .NET 9 packages (#8012) * Changed the runtime type for the Date scalar in Strawberry Shake (#8009) * Added Strawberry Shake runtime type change to migration guide (#8010) * Migrated to new solution file format. (#8027) * Combining the CompilationProvider is an anti-pattern, create an IncrementalValueProvider for the assembly name instead. (#8021) * Fixed ignored invalid field when enum is present (#8026) * Allow for internal DataLoader modules and groups. (#8028) * Updated the latest stable version for the docs to v15 (#8018) * Added documentation directory for Fusion v15 (#8017) * Added Strawberry Shake migration documents to `docs.json` (#8015) * [Fusion] Fix explosion of selections (#8030) --------- Co-authored-by: Daniel Reynolds <55194784+danielreynolds1@users.noreply.github.com> Co-authored-by: Michael Staib <michael@chillicream.com> Co-authored-by: Martin Gasser <m-gasser@gmx.net> Co-authored-by: faddiv <faddiv@gmail.com> Co-authored-by: Tobias Tengler <45513122+tobias-tengler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combining the CompilationProvider is an anti-pattern, create an IncrementalValueProvider for the assembly name instead.
See https://github.com/dotnet/roslyn/blob/main/docs/features/incremental-generators.md where combining the CompilationProvider is given as a sample how to not do it.