| Lists: | pgsql-hackers |
|---|
| From: | Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Apply PGDLLIMPORT markings to some GUC variables |
| Date: | 2024-08-13 14:38:42 |
| Message-ID: | e0b17014-5319-4dd6-91cd-93d9c8fc9539@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi hackers,
I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
header files. According to the commit message in 8ec569479, all
variables in header files must be marked with PGDLLIMPORT, am I right?
I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
--
Best regards,
Sofia Kopikova
Postgres Professional: http://www.postgrespro.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Apply-PGDLLIMPORT-markings-to-some-GUC-variables.patch | text/x-patch | 3.6 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Apply PGDLLIMPORT markings to some GUC variables |
| Date: | 2024-08-13 19:00:00 |
| Message-ID: | CA+TgmoZ+NDotjPyVWrBJNZvv2XLYnHq3uVkpQRGe5WdaoHxt8A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
<s(dot)kopikova(at)postgrespro(dot)ru> wrote:
> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
> header files. According to the commit message in 8ec569479, all
> variables in header files must be marked with PGDLLIMPORT, am I right?
>
> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
This seems correct to me.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Apply PGDLLIMPORT markings to some GUC variables |
| Date: | 2024-08-14 09:50:08 |
| Message-ID: | 859061b6-8aa6-49dc-be88-bdf7eebcbbb3@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 13.08.24 21:00, Robert Haas wrote:
> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
> <s(dot)kopikova(at)postgrespro(dot)ru> wrote:
>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>> header files. According to the commit message in 8ec569479, all
>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>
>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
>
> This seems correct to me.
committed
| From: | Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Apply PGDLLIMPORT markings to some GUC variables |
| Date: | 2024-08-14 10:14:48 |
| Message-ID: | 8ff5dbce-9eb2-4a22-b1dd-d6d387a5838c@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 8/14/24 12:50, Peter Eisentraut wrote:
> On 13.08.24 21:00, Robert Haas wrote:
>> On Tue, Aug 13, 2024 at 10:38 AM Sofia Kopikova
>> <s(dot)kopikova(at)postgrespro(dot)ru> wrote:
>>> I noticed that in commit d3cc5ffe81f6 some GUC variables were moved to
>>> header files. According to the commit message in 8ec569479, all
>>> variables in header files must be marked with PGDLLIMPORT, am I right?
>>>
>>> I've made a patch that adds missing PGDLLIMPORTs, please, take a look.
>>
>> This seems correct to me.
>
> committed
>
Many thanks for quick review and commit.
--
Best regards,
Sofia Kopikova
Postgres Professional: http://www.postgrespro.com
| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Apply PGDLLIMPORT markings to some GUC variables |
| Date: | 2024-08-19 06:18:20 |
| Message-ID: | ZsLjrPgdNkyXr7pW@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
> This seems correct to me.
It is not the first time that this happens in recent history. Would
it be worth automating that? I would guess a TAP test that takes a
copy of the headers, applies the changes while filtering the few
exceptions, then compares it to the origin in the tree?
--
Michael
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Sofia Kopikova <s(dot)kopikova(at)postgrespro(dot)ru>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Apply PGDLLIMPORT markings to some GUC variables |
| Date: | 2024-08-19 09:20:33 |
| Message-ID: | da997cd8-4e63-4a4b-ab09-8b51b4d19b2a@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 19.08.24 08:18, Michael Paquier wrote:
> On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
>> This seems correct to me.
>
> It is not the first time that this happens in recent history. Would
> it be worth automating that? I would guess a TAP test that takes a
> copy of the headers, applies the changes while filtering the few
> exceptions, then compares it to the origin in the tree?
Probably worth thinking about, but it would at least require some kind
of exclude list, because there are exceptions like src/include/common/
/logging.h.