| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Format list of catalog files in makefile vertically |
| Date: | 2023-08-25 13:12:51 |
| Message-ID: | a306be82-ee71-4554-d499-49a45a654396@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I propose to reformat the catalog lists in src/backend/catalog/Makefile
to be more vertical, one per line. This makes it easier to keep that
list in sync with src/include/catalog/meson.build, and visually compare
both lists. Also, it's easier to read and edit in general.
In passing, I'd also copy over some relevant comments from the makefile
to meson.build. For the hypothetical future when we delete the
makefiles, these comments seem worth keeping. (For fun, I tested
whether the comments are still true, and yes, the order still matters.)
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Format-list-of-catalog-files-in-makefile-vertically.patch | text/plain | 5.2 KB |
| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Format list of catalog files in makefile vertically |
| Date: | 2023-08-25 13:25:22 |
| Message-ID: | 48D94B16-A3A3-4C0F-A54B-3BBB13E45A95@anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On August 25, 2023 9:12:51 AM EDT, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>I propose to reformat the catalog lists in src/backend/catalog/Makefile to be more vertical, one per line. This makes it easier to keep that list in sync with src/include/catalog/meson.build, and visually compare both lists. Also, it's easier to read and edit in general.
>
>In passing, I'd also copy over some relevant comments from the makefile to meson.build. For the hypothetical future when we delete the makefiles, these comments seem worth keeping. (For fun, I tested whether the comments are still true, and yes, the order still matters.)
Makes sense to me.
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Format list of catalog files in makefile vertically |
| Date: | 2023-08-26 16:38:15 |
| Message-ID: | 20230826163815.bont3h5uvdcqgo6q@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2023-Aug-25, Peter Eisentraut wrote:
> I propose to reformat the catalog lists in src/backend/catalog/Makefile to
> be more vertical, one per line. This makes it easier to keep that list in
> sync with src/include/catalog/meson.build, and visually compare both lists.
> Also, it's easier to read and edit in general.
+1
> In passing, I'd also copy over some relevant comments from the makefile to
> meson.build. For the hypothetical future when we delete the makefiles,
> these comments seem worth keeping. (For fun, I tested whether the comments
> are still true, and yes, the order still matters.)
Sure.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La experiencia nos dice que el hombre peló millones de veces las patatas,
pero era forzoso admitir la posibilidad de que en un caso entre millones,
las patatas pelarían al hombre" (Ijon Tichy)