| From: | Zhang Mingli <zmlpostgres(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Simplify newNode() |
| Date: | 2023-12-14 01:34:26 |
| Message-ID: | bee3fb16-6182-405b-86e3-5767f27cb6ac@Spark |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
LGTM.
+ Assert(size >= sizeof(Node)); /* need the tag, at least */
+ result = (Node *) palloc0fast(size);
+ result->type = tag;
+ return result;
+}
How about moving the comments /* need the tag, at least */ after result->type = tag; by the way?
Zhang Mingli
www.hashdata.xyz
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2023-12-14 02:19:13 | Re: Simplify newNode() |
| Previous Message | Peter Smith | 2023-12-14 01:30:04 | Re: Synchronizing slots from primary to standby |