feat!: migrate to v2.0.0 #147
Conversation
|
Thank you for working on this!
|
Thanks! I wasn't sure what was missing.
The motivation was two fold. It separates the handwritten surfaces which makes it clearer to contributes what is written and what is generated. It also prevents having to customize the generated I'm happy to revert these files back to their original folder if you think that would be best.
Most of the handwritten surfaces are used directly by users. The major ones are:
However, the files that changed the most during migration are:
|
There was a problem hiding this comment.
I would prefer the handwritten code live in the versioned directory for consistency with the other libraries. It looks like firestore excludes __init__.py in synth.py https://github.com/googleapis/python-firestore/blob/c3acd4a04745c93edb2f61bf9be6fa33f439f4b0/synth.py#L41
Fully generated libraries use the unversioned path google/cloud/{api}/ for the default alias (equivalent of google/cloud/spanner.py) https://github.com/googleapis/python-speech/blob/master/google/cloud/speech/__init__.py so there's also a small chance for confusion there.
d1c3dab to
bf06add
Compare
Co-authored-by: skuruppu <skuruppu@google.com>
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/python-spanner/compare/v1.19.1...v2.0.0) (2020-11-11) ### ⚠ BREAKING CHANGES * migrate to v2.0.0 (#147) ### Features * DB-API driver + unit tests ([#160](https://www.github.com/googleapis/python-spanner/issues/160)) ([2493fa1](https://www.github.com/googleapis/python-spanner/commit/2493fa1725d2d613f6c064637a4e215ee66255e3)) * migrate to v2.0.0 ([#147](https://www.github.com/googleapis/python-spanner/issues/147)) ([bf4b278](https://www.github.com/googleapis/python-spanner/commit/bf4b27827494e3dc33b1e4333dfe147a36a486b3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
|
@larkee: In the end, the "breaking change" that shows up in the changelog was
which would have been much more useful |
|
@wyardley My apologies! I'll do my best to label changes better in future 👍 I'll update the changelog directly to show the more useful message |
This PR is a preview of the 2.0 release.
TODO list:
Fix docs.
Describe changes in UPGRADING guide.
BREAKING CHANGES
list_instances,list_databases,list_instance_configs, andlist_backupswill now return protos rather than the handwritten wrapper