8000 [PropertyInfo] consider write property visibility to decide whether a property is writable by xabbuh · Pull Request #58959 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] consider write property visibility to decide whether a property is writable #58959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

[PropertyInfo] consider write property visibility to decide whether a property is writable #58959

merged 1 commit into from
Nov 25, 2024

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Nov 21, 2024
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues part of #58556
License MIT

@xabbuh xabbuh requested a review from dunglas as a code owner November 21, 2024 13:49
@carsonbot carsonbot added this to the 5.4 milestone Nov 21, 2024
@xabbuh xabbuh mentioned this pull request Nov 21, 2024
Closed
@xabbuh xabbuh force-pushed the issue-58556-asymmetric-visibility branch from 65d636b to 30f70aa Compare November 21, 2024 15:37
@pan93412 pan93412 mentioned this pull request Nov 21, 2024
Merged
1 task
@xabbuh xabbuh force-pushed the issue-58556-asymmetric-visibility branch from 30f70aa to 49126e1 Compare November 21, 2024 15:54
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 520e31b into symfony:5.4 Nov 25, 2024
9 of 12 checks passed
@xabbuh xabbuh deleted the issue-58556-asymmetric-visibility branch November 25, 2024 11:23
nicolas-grekas added a commit that referenced this pull request Nov 25, 2024
@nicolas-grekas
bug #58963 [PropertyInfo] Fix write visibility for Asymmetric Visibil…
ec691c8 
…ity and Virtual Properties (xabbuh, pan93412)

This PR was merged into the 5.4 branch.

Discussion
----------

[PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #58556
| License       | MIT

- [ ] Rebase after #58959 and #58962 is merged.

Commits
-------

964bf1f [PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties
This was referenced Nov 27, 2024
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@pan93412 pan93412 pan93412 approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @alexandre-daubois @pan93412 @carsonbot
0