8000 [PropertyInfo] Check if the virtual property has a setter in `isAllowedProperty` by pan93412 · Pull Request #58962 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] Check if the virtual property has a setter in isAllowedProperty #58962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[PropertyInfo] Check if the virtual property has a setter in isAllowedProperty #58962

wants to merge 4 commits into from

Conversation

pan93412
Copy link
Contributor
@pan93412 pan93412 commented Nov 21, 2024 •
edited
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations?
Issues Fix #58556
License MIT

Separate from #58960

@pan93412 pan93412 requested a review from dunglas as a code owner November 21, 2024 15:30
@carsonbot carsonbot added this to the 5.4 milestone Nov 21, 2024
@pan93412
Copy link
Contributor Author

cc @xabbuh

This was referenced Nov 21, 2024
Merged
Closed
@pan93412 pan93412 force-pushed the issue-58556-property-hooks branch from 3f5efa7 to e1108ec Compare November 25, 2024 11:32
@pan93412
Copy link
Contributor Author
pan93412 commented Nov 25, 2024 •
edited
Loading

r? @nicolas-grekas (conflicts have been resolved)

@pan93412
Check if the virtual property has a setter in isAllowedProperty
b482f1b 
A virtual property without setter cannot be written.
@pan93412
Use PHP_VERSION_ID instead of method_exists
4fdf296 
Psalm does not matter. method_exists may introduce some unneeded overhead.
@pan93412
Add backed properties test
535b54d
@pan93412 pan93412 force-pushed the issue-58556-property-hooks branch from e1108ec to 535b54d Compare November 25, 2024 11:34
@OskarStark OskarStark changed the title [PropertyInfo] Check if the virtual property has a setter in isAllowedProperty [PropertyInfo] Check if the virtual property has a setter in isAllowedProperty Nov 25, 2024
nicolas-grekas added a commit that referenced this pull request Nov 25, 2024
@nicolas-grekas
bug #58963 [PropertyInfo] Fix write visibility for Asymmetric Visibil…
ec691c8 
…ity and Virtual Properties (xabbuh, pan93412)

This PR was merged into the 5.4 branch.

Discussion
----------

[PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #58556
| License       | MIT

- [ ] Rebase after #58959 and #58962 is merged.

Commits
-------

964bf1f [PropertyInfo] Fix write visibility for Asymmetric Visibility and Virtual Properties
@pan93412
Copy link
Contributor Author

Superseded by #58963.

@pan93412 pan93412 closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@pan93412 @nicolas-grekas @carsonbot
0