chore(Demos): Replace notification buttons with NotificationBadge#11497
chore(Demos): Replace notification buttons with NotificationBadge#11497thatblindgeye merged 2 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-react-pr-11497.surge.sh A11y report: https://patternfly-react-pr-11497-a11y.surge.sh |
There was a problem hiding this comment.
Looks like there's one more instance in the react-tables package (in the src/demos/DashboardHeader.tsx file)
ff2a7fa to
8898249
Compare
👍 Good catch, I was only searching in core. Fixed and made sure there were no other instances anywhere else. |
There was a problem hiding this comment.
Thanks for the updates.
I think this is more a core issue but I noticed the border changes to 2px width on hover which is different from our designs where we only change color not border-width. I'll confirm with @lboehling and @kaylachumley
There was a problem hiding this comment.
My earlier comment is related to button CSS so this is good to go. thanks!
What: Closes #10625