8000 chore(Demos): Replace notification buttons with NotificationBadge by mfrances17 · Pull Request #11497 · patternfly/patternfly-react · GitHub
[go: up one dir, main page]
Skip to content

chore(Demos): Replace notification buttons with NotificationBadge #11497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatblindgeye merged 2 commits into from
Feb 11, 2025
Merged

chore(Demos): Replace notification buttons with NotificationBadge #11497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d72d4
chore(Demos): Replace notification buttons with NotificationBadge
mfrances17 Feb 3, 2025
8898249
apply same changes to table
mfrances17 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-core/src/demos/DashboardHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import {
MastheadLogo,
MastheadContent,
MenuToggle,
NotificationBadge,
NotificationBadgeVariant,
Toolbar,
ToolbarContent,
ToolbarGroup,
Expand All @@ -26,7 +28,6 @@ import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg';
import pfLogo from '@patternfly/react-core/src/demos/assets/PF-HorizontalLogo-Color.svg';
Expand Down Expand Up @@ -108,10 +109,9 @@ export const DashboardHeader: React.FC<DashboardHeaderProps> = ({ notificationBa
>
{notificationBadge ?? (
<ToolbarItem>
<Button
<NotificationBadge
aria-label="Notifications"
variant={ButtonVariant.plain}
icon={<BellIcon />}
variant={NotificationBadgeVariant.read}
onClick={() => {}}
/>
</ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Masthead/MastheadWithHorizontalNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
SkipToContent,
Expand All @@ -35,7 +37,6 @@ import {
ToolbarItem
} from '@patternfly/react-core';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
Expand Down Expand Up @@ -188,7 +189,7 @@ export const MastheadWithHorizontalNav: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Masthead/MastheadWithUtilitiesAndUserDropdownMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
PageSidebar,
Expand All @@ -50,7 +52,6 @@ import {
import { Link } from '@reach/router';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import ThIcon from '@patternfly/react-icons/dist/esm/icons/th-icon';
Expand Down Expand Up @@ -385,7 +386,7 @@ export const MastheadWithUtilitiesAndUserDropdownMenu: React.FunctionComponent =
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem visibility={{ default: 'hidden', md: 'hidden', lg: 'visible' }}>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Nav/NavFlyout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
PageSidebar,
Expand All @@ -35,7 +37,6 @@ import {
ToolbarItem
} from '@patternfly/react-core';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
Expand Down Expand Up @@ -134,7 +135,7 @@ export const NavFlyout: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} onClick={() => {}} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Nav/NavHorizontal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
SkipToContent,
Expand All @@ -35,7 +37,6 @@ import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg';
import pfLogo from '@patternfly/react-core/src/demos/assets/PF-HorizontalLogo-Color.svg';
import { DashboardBreadcrumb } from '@patternfly/react-core/dist/js/demos/DashboardWrapper';
Expand Down Expand Up @@ -112,7 +113,7 @@ export const NavHorizontal: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} onClick={() => {}} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Nav/NavHorizontalWithSubnav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
PageSectionTypes,
Expand All @@ -37,7 +39,6 @@ import {
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg';
Expand Down Expand Up @@ -161,7 +162,7 @@ export const NavHorizontalWithSubnav: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} onClick={() => {}} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Nav/NavManual.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
PageSidebar,
Expand All @@ -39,7 +41,6 @@ import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import imgAvatar from '@patternfly/react-core/src/components/assets/avatarImg.svg';
import pfLogo from '@patternfly/react-core/src/demos/assets/PF-HorizontalLogo-Color.svg';
Expand Down Expand Up @@ -128,7 +129,7 @@ export const NavManual: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} onClick={() => {}} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Page/PageContextSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
PageSidebar,
Expand All @@ -39,7 +41,6 @@ import {
ToolbarItem
} from '@patternfly/react-core';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
Expand Down Expand Up @@ -141,7 +142,7 @@ export const PageStickySectionBreadcrumb: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Page/PageStickySectionBreadcrumb.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
PageSidebar,
Expand All @@ -39,7 +41,6 @@ import {
ToolbarItem
} from '@patternfly/react-core';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
Expand Down Expand Up @@ -124,7 +125,7 @@ export const PageStickySectionBreadcrumb: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Page/PageStickySectionGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageSection,
PageSidebar,
Expand All @@ -39,7 +41,6 @@ import {
ToolbarItem
} from '@patternfly/react-core';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
Expand Down Expand Up @@ -124,7 +125,7 @@ export const PageStickySectionGroup: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
5 changes: 3 additions & 2 deletions packages/react-core/src/demos/examples/Page/PageStickySectionGroupAlternate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ import {
Nav,
NavItem,
NavList,
NotificationBadge,
NotificationBadgeVariant,
Page,
PageBreadcrumb,
PageGroup,
Expand All @@ -41,7 +43,6 @@ import {
ToolbarItem
} from '@patternfly/react-core';
import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
Expand Down Expand Up @@ -116,7 +117,7 @@ export const PageStickySectionGroupAlternate: React.FunctionComponent = () => {
gap={{ default: 'gapNone', md: 'gapMd' }}
>
<ToolbarItem>
<Button aria-label="Notifications" variant={ButtonVariant.plain} icon={<BellIcon />} />
<NotificationBadge aria-label="Notifications" variant={NotificationBadgeVariant.read} onClick={() => {}} />
</ToolbarItem>
<ToolbarGroup variant="action-group-plain" visibility={{ default: 'hidden', lg: 'visible' }}>
<ToolbarItem>
Expand Down
8 changes: 4 additions & 4 deletions packages/react-table/src/demos/DashboardHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import {
MastheadLogo,
MastheadContent,
MenuToggle,
NotificationBadge,
NotificationBadgeVariant,
Toolbar,
ToolbarContent,
ToolbarGroup,
Expand All @@ -26,7 +28,6 @@ import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon';
import CogIcon from '@patternfly/react-icons/dist/esm/icons/cog-icon';
import HelpIcon from '@patternfly/react-icons/dist/esm/icons/help-icon';
import QuestionCircleIcon from '@patternfly/react-icons/dist/esm/icons/question-circle-icon';
import BellIcon from '@patternfly/react-icons/dist/esm/icons/bell-icon';
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
import imgAvatar from '@patternfly/react-table/src/demos/assets/avatarImg.svg';
import pfLogo from '@patternfly/react-table/src/demos/assets/pf-logo.svg';
Expand Down Expand Up @@ -108,10 +109,9 @@ export const DashboardHeader: React.FC<DashboardHeaderProps> = ({ notificationBa
>
{notificationBadge ?? (
<ToolbarItem>
<Button
<NotificationBadge
aria-label="Notifications"
variant={ButtonVariant.plain}
icon={<BellIcon />}
variant={NotificationBadgeVariant.read}
onClick={() => {}}
/>
</ToolbarItem>
Expand Down
Loading
0