8000 Deprecate code in goyaml.v2 (and v3) directories and redirect to equivalents in go.yaml.in/yaml/v2 (and v3) by dims · Pull Request #133 · kubernetes-sigs/yaml · GitHub
[go: up one dir, main page]
Skip to content
/ yaml Public
forked from ghodss/yaml

Deprecate code in goyaml.v2 (and v3) directories and redirect to equivalents in go.yaml.in/yaml/v2 (and v3) #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Deprecate code in goyaml.v2 (and v3) directories and redirect to equivalents in go.yaml.in/yaml/v2 (and v3) #133

merged 1 commit into from
Jun 24, 2025
+300 −29,652

Conversation

dims
Copy link
Member
@dims dims commented Jun 14, 2025

Context: please see kubernetes/kubernetes#132056

Let us get us and everyone else to move to the revived repos under YAML org:

Follows the suggestion laid out by @thockin in:
kubernetes/kubernetes#132056 (comment)

8000
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 14, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2025
@dims dims force-pushed the deprecate-code-in-goyaml.v3-goyaml.v2-and-redirect branch from ad1a62b to d370760 Compare June 14, 2025 00:22
@dims
Deprecate code in goyaml.v2/goyaml.v3 directories and redirect
69e45c1 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the deprecate-code-in-goyaml.v3-goyaml.v2-and-redirect branch from d370760 to 69e45c1 Compare June 14, 2025 00:27
@dims
Copy link
Member Author
dims commented Jun 17, 2025

/assign @thockin @liggitt

@liggitt
Copy link
liggitt commented Jun 17, 2025

it would be helpful to have the question at kubernetes/kubernetes#132056 (comment) answered before we make this change ... knowing the intent of the upstream in terms of activity, changes, churn, etc, would be really helpful

@ingydotnet
Copy link

it would be helpful to have the question at kubernetes/kubernetes#132056 (comment) answered before we make this change ... knowing the intent of the upstream in terms of activity, changes, churn, etc, would be really helpful

kubernetes/kubernetes#132056 (comment)

@liggitt does that work?

@dims dims mentioned this pull request Jun 18, 2025
Open
@wwqgtxx wwqgtxx mentioned this pull request Jun 18, 2025
Merged
liggitt
liggitt reviewed Jun 24, 2025
View reviewed changes
liggitt
liggitt reviewed Jun 24, 2025
View reviewed changes
@liggitt
Copy link
liggitt commented Jun 24, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8eaa802 into master Jun 24, 2025
6 checks passed
@dims dims mentioned this pull request Jun 25, 2025
Merged
@dims
Copy link
Member Author
dims commented Jun 25, 2025

xref: kubernetes/kubernetes#132056

@dims dims mentioned this pull request Jun 25, 2025
Merged
@HadrienPatte HadrienPatte mentioned this pull request Jun 25, 2025
Merged
@Luap99 Luap99 mentioned this pull request Jun 26, 2025
Open
@HadrienPatte HadrienPatte mentioned this pull request Jun 26, 2025
Merged
8 tasks
@Okabe-Junya Okabe-Junya mentioned this pull request Jun 27, 2025
Merged
@renovate renovate bot mentioned this pull request Aug 13, 2025
Open
1 task
@sylr sylr mentioned this pull request Sep 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @liggitt @ingydotnet @k8s-ci-robot @thockin
0