8000 Forgot to add redirects for v3 constants by dims · Pull Request #134 · kubernetes-sigs/yaml · GitHub
[go: up one dir, main page]
Skip to content

Forgot to add redirects for v3 constants #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Forgot to add redirects for v3 constants #134

merged 1 commit into from
Jun 25, 2025
+53 −3

Conversation

dims
Copy link
Member
@dims dims commented Jun 25, 2025

Found when i throw sigs.k8s.io/yaml HEAD into the chopper with k/k, typecheck showed that i forgot to add redirects for public constants when i filed #133

kubernetes/kubernetes#132357
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/132357/pull-kubernetes-typecheck/1937844052523225088

ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:84:32: undefined: yaml.AliasNode
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:85:35: undefined: yaml.DocumentNode
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:86:34: undefined: yaml.MappingNode
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:87:33: undefined: yaml.ScalarNode
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:88:35: undefined: yaml.SequenceNode
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:100:41: undefined: yaml.DoubleQuotedStyle
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:101:33: undefined: yaml.FlowStyle
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:102:35: undefined: yaml.FoldedStyle
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:103:36: undefined: yaml.LiteralStyle
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:104:41: undefined: yaml.SingleQuotedStyle
ERROR(linux/arm): /home/prow/go/src/k8s.io/kubernetes/vendor/sigs.k8s.io/kustomize/kyaml/yaml/alias.go:105:35: undefined: yaml.TaggedStyle

cross checked that v2 does not have similar constants!

@dims
Forgot to add redirects for v3 constants
b8fc0c0 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2025
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz June 25, 2025 13:23
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 25, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2025
@dims
Copy link
Member Author
dims commented Jun 25, 2025

/assign @liggitt @thockin

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2025
@liggitt
Copy link
liggitt commented Jun 25, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0f318dc into master Jun 25, 2025
6 checks passed
@dims
Copy link
Member Author
dims commented Jun 25, 2025

xref: kubernetes/kubernetes#132056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dims @liggitt @k8s-ci-robot @thockin
0