8000 kep-3716 GA, remove feature gate by ivelichkovich · Pull Request #123560 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

kep-3716 GA, remove feature gate #123560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

kep-3716 GA, remove feature gate #123560

merged 1 commit into from
Mar 1, 2024

Conversation

ivelichkovich
Copy link
Contributor
@ivelichkovich ivelichkovich commented Feb 28, 2024 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

removes feature gate for kep-3716 match conditions promoting to GA

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote AdmissionWebhookMatchConditions to GA. The feature is now stable and the feature gate is now locked to default.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: [<link>](https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3716-admission-webhook-match-conditions)

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from deads2k February 28, 2024 17:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dims February 28, 2024 17:00
@k8s-ci-robot k8s-ci-robot added area/apiserver area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 28, 2024
@ivelichkovich
Copy link
Contributor Author

updating code gen

@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Feb 28, 2024
Closed
12 tasks
@sftim
Copy link
Contributor
sftim commented Feb 28, 2024

Changelog suggestion

-match conditions to GA, removes feature flag
+Removed the `AdmissionWebhookMatchConditions` feature gate. The feature was already stable and the
+feature gate was previously locked to enabled.

@ivelichkovich
Copy link
Contributor Author

Changelog suggestion

-match conditions to GA, removes feature flag
+Removed the `AdmissionWebhookMatchConditions` feature gate. The feature was already stable and the
+feature gate was previously locked to enabled.

Thanks! updated along those lines.

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ivelichkovich ivelichkovich mentioned this pull request Feb 28, 2024
Merged
@ivelichkovich
Copy link
Contributor Author

PR for e2e tests: #123564

@jpbetz
Copy link
Contributor
jpbetz commented Feb 28, 2024

/approve
/lgtm
Looks good. I don't see anything surprising here. If CI is green, I'm okay with this merging.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f1bedeb2ace955e1afe797ebd122f6835b17c40

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz February 28, 2024 18:43
@deads2k
Copy link
Contributor
deads2k commented Feb 29, 2024
8000

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b56a316e52b31f19e01663c234a5f66c1ceb4193

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ivelichkovich, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@pacoxu
Copy link
Member
pacoxu commented Mar 1, 2024

UT ci failed for #123603

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@pacoxu
Copy link
Member
pacoxu commented Mar 1, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6cc77a5 into kubernetes:master Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 1, 2024
@cici37 cici37 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@dims dims Awaiting requested review from dims

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@jpbetz jpbetz

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
8 participants
@ivelichkovich @sftim @k8s-triage-robot @jpbetz @k8s-ci-robot @deads2k @pacoxu @cici37
0