8000 fix UT failure TestPrintIPAddressList by pacoxu · Pull Request #123603 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

fix UT failure TestPrintIPAddressList #123603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix UT failure TestPrintIPAddressList #123603

merged 1 commit into from
Mar 1, 2024

Conversation

pacoxu
Copy link
Member
@pacoxu pacoxu commented Mar 1, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot requested review from dims and liggitt March 1, 2024 02:50
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 1, 2024
@pacoxu
Copy link
Member Author
pacoxu commented Mar 1, 2024

It failed after UTC 03-01, and seems to be related to 2024-02-29.

@pacoxu
Copy link
Member Author
pacoxu commented Mar 1, 2024

/assign @soltysh @eddiezane

This was referenced Mar 1, 2024
Merged
Merged
liggitt
liggitt reviewed Mar 1, 2024
View reviewed changes
@pacoxu pacoxu force-pushed the patch-11 branch 2 times, most recently from 5a9b0e4 to 28ab615 Compare March 1, 2024 03:14
liggitt
liggitt reviewed Mar 1, 2024
View reviewed changes
@liggitt
Copy link
Member
liggitt commented Mar 1, 2024

/priority critical-urgent
/kind failing-test
/sig networking

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

@liggitt: The label(s) sig/networking cannot be applied, because the repository doesn't have them.

In response to this:

/priority critical-urgent
/kind failing-test
/sig networking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 1, 2024
@liggitt
Copy link
Member
liggitt commented Mar 1, 2024

/lgtm
/approve

thanks! can you go ahead and open cherry-picks to 1.27 - 1.29?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0143dd89bacf79ddc3372a29f0680b988fcf0a34

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@pacoxu pacoxu mentioned this pull request Mar 1, 2024
Merged
@liggitt liggitt mentioned this pull request Mar 1, 2024
Merged
@pacoxu pacoxu mentioned this pull request Mar 1, 2024
Merged
@pacoxu
Copy link
Member Author
pacoxu commented Mar 1, 2024

thanks! can you go ahead and open cherry-picks to 1.27 - 1.29?

#123605
#123606
#123607

This was referenced Mar 1, 2024
Merged
Merged
@pacoxu
Copy link
Member Author
pacoxu commented Mar 1, 2024

/sig network cli

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2024
@liggitt liggitt mentioned this pull request Mar 1, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit 5fd3bc0 into kubernetes:master Mar 1, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 1, 2024
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2024
@k8s-ci-robot
Merge pull request #123606 from pacoxu/automated-cherry-pick-of-#1236…
a5a2704 
…03-upstream-release-1.28

Automated cherry pick of #123603: fix UT failure TestPrintIPAddressList
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2024
@k8s-ci-robot
Merge pull request #123607 from pacoxu/automated-cherry-pick-of-#1236…
8f01b99 
…03-upstream-release-1.27

Automated cherry pick of #123603: fix UT failure TestPrintIPAddressList
k8s-ci-robot added a commit that referenced this pull request Mar 1, 2024
@k8s-ci-robot
Merge pull request #123605 from pacoxu/automated-cherry-pick-of-#1236…
52b96e9 
…03-upstream-release-1.29

Automated cherry pick of #123603: fix UT failure TestPrintIPAddressList
@ffromani ffromani mentioned this pull request Mar 13, 2024
Merged
This was referenced Mar 15, 2024
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 25, 2024
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 21, 2024
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt liggitt left review comments

@dims dims Awaiting requested review from dims

Assignees

@soltysh soltysh

@eddiezane eddiezane

@liggitt liggitt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

SIG CLI
Archived in project

Milestone

v1.30

Development

Successfully merging this pull request may close these issues.

[Failing-test] UT TestPrintIPAddressList for leap day

5 participants

@pacoxu @k8s-ci-robot @liggitt @soltysh @eddiezane
0