blender/blender
blender/blender
185
592
Fork 918
Code Issues 6.3k Pull Requests 1.1k Projects 22 Wiki Activity

SVG: Batch import SVG as curves files #134795

Merged
Sergey Sharybin merged 3 commits from Maxime-Cots/blender:feat-svg-batch-import into main 2025-02-21 12:41:34 +01:00
Conversation 9 Commits 3 Files Changed 1 +22 -2
Maxime-Cots commented 2025-02-19 12:03:46 +01:00
Contributor
Copy Link

Hello,

I found that SVG was missing batch import of multiple files during my work on an other issue, so I implemented it

Feel free to comment ! And report if I missed something !

Hello, I found that SVG was missing batch import of multiple files during my work on an other issue, so I implemented it Feel free to comment ! And report if I missed something !
batch-import-svg-as-curves.mp4
325 KiB
❤️ 3
Maxime-Cots added 1 commit 2025-02-19 12:03:48 +01:00
Maxime-Cots requested review from Sergey Sharybin 2025-02-19 12:03:49 +01:00
RedMser reviewed 2025-02-19 15:43:40 +01:00
scripts/addons_core/io_curve_svg/__init__.py Outdated
@ -34,13 +38,30 @@ class ImportSVG(bpy.types.Operator, ImportHelper):
bl_label = "Import SVG"
bl_options = {'UNDO'}
directory: StringProperty()
RedMser commented 2025-02-19 15:43:40 +01:00
Contributor
Copy Link

Seems to be unused.

Seems to be unused.
Maxime-Cots commented 2025-02-19 21:33:17 +01:00
Author
Contributor
Copy Link

I removed it ! Thanks

I removed it ! Thanks
Maxime-Cots marked this conversation as resolved
Maxime-Cots added 1 commit 2025-02-19 21:19:17 +01:00
Sergey Sharybin requested review from Campbell Barton 2025-02-20 11:04:43 +01:00
Sergey Sharybin commented 2025-02-20 11:07:42 +01:00
Owner
Copy Link

Thanks for looking into it!

It seems you need to run autopep8 in the file to correct style and remove trailing whitespace. Running make format should take care of that. There are some details in the documentation.

What I am not sure is whether it is required to explicitly handle single file import, similar to glTF. @ideasman42 is it something you can help with?

Thanks for looking into it! It seems you need to run autopep8 in the file to correct style and remove trailing whitespace. Running `make format` should take care of that. There are some details in the [documentation](https://developer.blender.org/docs/handbook/guidelines/python/#automated-formatting). What I am not sure is whether it is required to explicitly handle single file import, similar to [glTF](https://projects.blender.org/blender/blender/src/branch/main/scripts/addons_core/io_scene_gltf2/__init__.py#L1974). @ideasman42 is it something you can help with?
Campbell Barton commented 2025-02-20 11:34:24 +01:00
Owner
Copy Link

@Sergey while from the file selector files should always be set to contain the file (even if it's not selected), I think it's best to handle both as it's expected that IO operators can take a filepath argument (when called from Python).

So this PR LGTM.

@Sergey while from the file selector `files` should always be set to contain the file (even if it's not selected), I think it's best to handle both as it's expected that IO operators can take a `filepath` argument (when called from Python). So this PR LGTM.
Sergey Sharybin commented 2025-02-20 11:48:22 +01:00
Owner
Copy Link

@ideasman42 I am confused. The current PR does not handle filepath, so it needs to be added?

@ideasman42 I am confused. The current PR does not handle `filepath`, so it needs to be added?
Campbell Barton requested changes 2025-02-20 12:01:57 +01:00
Dismissed
scripts/addons_core/io_curve_svg/__init__.py Outdated
@ -40,2 +50,4 @@
def execute(self, context):
from . import import_svg
if not self.files:
Campbell Barton commented 2025-02-20 12:01:50 +01:00
Owner
Copy Link

These checks would be a bit easier to follow (as glTF uses)

if self.files:
    .... use files ...
else:
   .... use filepath ...

Edit I don't feel too strongly about this, an early return can be OK too, it's just that most scripts in Blender check files first instead of the not self.files case.

These checks would be a bit easier to follow (as glTF uses) ``` if self.files: .... use files ... else: .... use filepath ... ``` *Edit* I don't feel too strongly about this, an early return can be OK too, it's just that most scripts in Blender check files first instead of the `not self.files` case.
Maxime-Cots commented 2025-02-21 09:28:49 +01:00
Author
Contributor
Copy Link

I removed it 👍

I removed it 👍
Maxime-Cots marked this conversation as resolved
Campbell Barton commented 2025-02-20 12:02:50 +01:00
Owner
Copy Link

@ideasman42 I am confused. The current PR does not handle filepath, so it needs to be added?

The code does but it was handled as an early return, requested to follow the same checks as glTF although I don't feel that strongly about it.

> @ideasman42 I am confused. The current PR does not handle `filepath`, so it needs to be added? The code does but it was handled as an early return, requested to follow the same checks as glTF although I don't feel that strongly about it.
Maxime-Cots added 1 commit 2025-02-21 09:27:51 +01:00
Maxime-Cots commented 2025-02-21 09:29:23 +01:00
Author
Contributor
Copy Link

Early return and trailing whitespace removed !

Early return and trailing whitespace removed !
Campbell Barton approved these changes 2025-02-21 11:08:52 +01:00
Sergey Sharybin commented 2025-02-21 12:40:39 +01:00
Owner
Copy Link

Thanks for the PR and review!

Thanks for the PR and review!
Sergey Sharybin merged commit 251cd8eb10 into main 2025-02-21 12:41:34 +01:00
Sergey Sharybin deleted branch feat-svg-batch-import 2025-02-21 12:41:35 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sergey Sharybin
Campbell Barton
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu BassamKurdali bassam kurdali gfxcoder jon denning
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#134795
No description provided.
Delete Branch "Maxime-Cots/blender:feat-svg-batch-import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?