blender/blender
blender/blender
185
593
Fork 918
Code Issues 6.3k Pull Requests 1.1k Projects 22 Wiki Activity

Fix #102737: Keyframe jump operator includes hidden curves in Graph Editor #108549

Merged
Christoph Lendenfeld merged 1 commits from ChrisLend/blender:fix_graph_keyframe_jump into blender-v3.6-release 2023-06-08 11:02:24 +02:00
Conversation 3 Commits 1 Files Changed 5 +112 -1
Christoph Lendenfeld commented 2023-06-02 16:40:16 +02:00
Member
Copy Link

The graph editor has the function to hide the display of FCurves and to only draw keyframes on selected curves.

Both options were not respected when executing the frame jump operator, meaning it would jump to potentially hidden keyframes.

This patch adds a new operator that is specific to the Graph Editor and that respects those features.

The only possible issue that could arise from this is a slight confusion for the user why they behave differently between editors. Especially with only the Graph Editor and the 3D view open. In general I think it's an improvement and follows the "you can only modify what you see" mantra in blender

Also
Resolves #97701

I had a look at changing the existing operator, but the keylist generation has no notion of where it is being called from, and IMO it shouldn't need to. So the logical conclusion was a more specific modifier in the GE.

The graph editor has the function to hide the display of FCurves and to only draw keyframes on selected curves. Both options were not respected when executing the frame jump operator, meaning it would jump to potentially hidden keyframes. This patch adds a new operator that is specific to the Graph Editor and that respects those features. The only possible issue that could arise from this is a slight confusion for the user why they behave differently between editors. Especially with only the Graph Editor and the 3D view open. In general I think it's an improvement and follows the "you can only modify what you see" mantra in blender Also Resolves #97701 ------ I had a look at changing the existing operator, but the keylist generation has no notion of where it is being called from, and IMO it shouldn't need to. So the logical conclusion was a more specific modifier in the GE.
Christoph Lendenfeld added the
Module
Animation & Rigging
 label 2023-06-02 16:40:32 +02:00
Christoph Lendenfeld requested review from Sybren A. Stüvel 2023-06-02 17:03:32 +02:00
Sybren A. Stüvel approved these changes 2023-06-06 17:13:36 +02:00
Sybren A. Stüvel left a comment
Member
Copy Link

LGTM! Just a small request, can be done before landing.

LGTM! Just a small request, can be done before landing.
source/blender/editors/screen/screen_ops.c Outdated
@ -3182,1 +3182,4 @@
static bool keyframe_jump_poll(bContext *C)
{
return ED_operator_screenactive_norender(C) && CTX_wm_area(C)->spacetype != SPACE_GRAPH;
Sybren A. Stüvel commented 2023-06-06 17:11:41 +02:00
Member
Copy Link

Maybe add acomment that explains that there is another operator for this specifically for the graph editor.

Maybe add acomment that explains that there is another operator for this specifically for the graph editor.
Christoph Lendenfeld force-pushed fix_graph_keyframe_jump from fd01f0bf21 to 1279787f56 2023-06-08 10:41:08 +02:00 Compare
Christoph Lendenfeld changed title from Fix #102737: Keyframe jump operator includes hidden curves in Graph Editor to Fix #102737: Keyframe jump operator includes hidden curves in Graph Editor 2023-06-08 10:41:09 +02:00
Christoph Lendenfeld changed target branch from main to blender-v3.6-release 2023-06-08 10:41:11 +02:00
Christoph Lendenfeld merged commit 2387290e4f into blender-v3.6-release 2023-06-08 11:02:24 +02:00
Christoph Lendenfeld deleted branch fix_graph_keyframe_jump 2023-06-08 11:02:30 +02:00
Tajino commented 2023-08-03 18:41:08 +02:00
First-time contributor
Copy Link

The new graph.keyframe_jump is working incorrectly in NLA tweak strips actions mode with pinned on and the strip has frame start offset or time scale.

The operator jumps to the keyframes of the source action instead of the pinned time remapped keyframes.

screen.keyframe_jump works as expected, but not this new graph.keyframe_jump

Steps to reproduce

  1. Open the attached "graph.keyframe_jump_NLA-test.blend"
  2. With the "Cube" object selected and the NLA strip "CubeAction" selected in the NLA editor, press 'Tab' to enter tweak strip actions mode
  3. With the mouse over Graph Editor, press the default 'up' or 'down' arrow keys to jump to next or previous keyframes.
The new graph.keyframe_jump is working incorrectly in NLA tweak strips actions mode with pinned on and the strip has frame start offset or time scale. The operator jumps to the keyframes of the source action instead of the pinned time remapped keyframes. screen.keyframe_jump works as expected, but not this new graph.keyframe_jump **Steps to reproduce** 1. Open the attached "graph.keyframe_jump_NLA-test.blend" 2. With the "Cube" object selected and the NLA strip "CubeAction" selected in the NLA editor, press 'Tab' to enter tweak strip actions mode 3. With the mouse over Graph Editor, press the default 'up' or 'down' arrow keys to jump to next or previous keyframes.
graph.keyframe_jump_NLA-test.blend
90 KiB
Christoph Lendenfeld commented 2023-08-04 11:25:21 +02:00
Author
Member
Copy Link

@Tajino thanks for letting us know. In the future please make a new bug report, this makes it easier for us to track
I made on now #110789: Keyframe jump operator in the Graph Editor does not respect NLA offset

@Tajino thanks for letting us know. In the future please make a new bug report, this makes it easier for us to track I made on now [#110789: Keyframe jump operator in the Graph Editor does not respect NLA offset](https://projects.blender.org/blender/blender/issues/110789)
Sign in to join this conversation.
Reviewers
No Reviewers
Sybren A. Stüvel
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Module
Animation & Rigging
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu BassamKurdali bassam kurdali gfxcoder jon denning
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#108549
No description provided.
Delete Branch "ChrisLend/blender:fix_graph_keyframe_jump"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?