On an empty change on top of the master branch ( https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1064336 ), CI now fails for GrowthExperiments:
00:33:13.607 There was 1 failure: 00:33:13.607 00:33:13.607 1) MediaWiki\Skins\Vector\Tests\Structure\PerformanceBudgetTest::testTotalModulesSize with data set "vector-2022" ('vector-2022', array('50KB', '21KB')) 00:33:13.608 T346813: Performance budget for styles in skin vector-2022 on main article namespace has been exceeded. Total size of styles modules is 23.5 Kbs is greater than the current budget size of 23 Kbs (see Vector/bundlesize.config.json). 00:33:13.608 If you are adding code on page load, please reduce styles that you are loading on page load or talk to the web team about increasing the budget. 00:33:13.608 If you are not adding code, and this seems to be an error, it is possible that something running without CI has bypassed this check and we can address this separately.Please reach out to the web team to discuss this via Phabricator or #talk-to-web.[PLEASE DO NOT SKIP THIS TEST. If this is blocking a deploy this might signal a potential performance regression with the desktop site.Instead of skipping the test you can increase the value in bundlesize.config.json and create a ticket to investigate this error. If the error is > 1kb please tag this as a train blocker.Please tag the ticket #Web-Team-Backlog. 00:33:13.608 00:33:13.608 The following modules are enabled on page load: 00:33:13.608 skins.vector.search.codex.styles 00:33:13.609 skins.vector.styles 00:33:13.609 skins.vector.icons 00:33:13.609 ext.flaggedRevs.basic 00:33:13.609 ext.uls.pt 00:33:13.609 ext.visualEditor.desktopArticleTarget.noscript 00:33:13.609 wikibase.client.init 00:33:13.609 wikibase.client.data-bridge.externalModifiers 00:33:13.609 ext.wikimediaBadges 00:33:13.609 ext.wikimediamessages.styles 00:33:13.609 site.styles 00:33:13.609 noscript 00:33:13.609 user.styles 00:33:13.609 Failed asserting that 23974 is equal to 23504.0 or is less than 23504.0. 00:33:13.609 00:33:13.609 /workspace/src/skins/Vector/tests/phpunit/structure/PerformanceBudgetTest.php:212
It would be nice to actually identify the source of this change in the style modules, since it is obviously not this change to GrowthExperiments.