Heading of the 'Since' column on Special:PendingChanges has a larger text size than other columns
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Mon, Aug 19, 8:43 AM

Description

The Since column heading is has a larger font size than the other column headings. This appears to be because the column is set to have more of a larger font size when it is sortable and appears to me to be due to Codex as opposed to any style set by the FlaggedRevs extension.

Firefox:

Chrome:

Steps to replicate the issue

Protect a page with pending changes enabled
Make an edit to the page while logged out
Visit Special:PendingChanges

What happens?:
The Since column heading has a larger size than any other column heading

What should have happened instead?:
The font size of all columns should be equal

Version information

Firefox 129.0.1 (64-bit) or Chrome, local install running latest FlaggedRevs code.

Also seen on https://en.wikipedia.org with Firefox

Acceptance Criteria

Demonstrate in Patchdemo that the issue has been fixed in a live example of Special:RecentChanges (using the steps to replicate that are described above)

Details

Subject	Repo	Branch	Lines +/-
Update Codex from v1.11.0 to v1.11.1	mediawiki/core	master	+318 -125
Table: sortable columns inherit font styles	design/codex	main	+2 -1
Normalize font size for sortable column headings	mediawiki/extensions/FlaggedRevs	master	+5 -0

Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Mon, Aug 19, 8:43 AM

Restricted Application added a project: Design-System-Team. · View Herald TranscriptMon, Aug 19, 8:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Dreamy_Jazz updated the task description. (Show Details)Mon, Aug 19, 8:45 AM

Dreamy_Jazz updated the task description. (Show Details)Mon, Aug 19, 8:49 AM

Looking at the code, the .cdx-table__table__sort-button class has the CSS rule font-size: 1rem; applied to matching elements. No such font-size is applied to the other elements, so it seems that the default font size is applied (in this case from the browser).

On a second look, I'm not so sure that this is because of Codex as the classes are added manually in the PendingChangesPager.

Dreamy_Jazz added a project: Codex.Mon, Aug 19, 9:02 AM

Adding back Codex because I've found that this may also be something about the font-family value:

'Since' column by default	'Since' column with font-family set to `sans-serif` (the value for other columns)

It seems that Firefox has the value of MS Shell Dlg \32 unless I add font-family: sans-serif; into the CSS styles for .cdx-table__table__sort-button elements:

Also a webfonts-changed class is added to the button (which I think might be unrelated).

Dreamy_Jazz added a project: Design-System-Team.Mon, Aug 19, 9:10 AM

Change #1063759 had a related patch set uploaded (by Abaris; author: Abaris):

[mediawiki/extensions/FlaggedRevs@master] Normalize font size for sortable column headings

https://gerrit.wikimedia.org/r/1063759

gerritbot added a project: Patch-For-Review.Mon, Aug 19, 9:59 AM

bmartinezcalvo set the point value for this task to 2.Mon, Aug 19, 6:04 PM

bmartinezcalvo edited projects, added Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)); removed Design-System-Team.

lwatson claimed this task.Mon, Aug 19, 7:40 PM

Change #1064067 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] Table: sortable columns inherit font styles

https://gerrit.wikimedia.org/r/1064067

• Catrope moved this task from Committed to Pending Release on the Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)) board.Tue, Aug 20, 6:43 PM

Change #1063759 abandoned by Abaris:

[mediawiki/extensions/FlaggedRevs@master] Normalize font size for sortable column headings

Reason:

Due to the 1064067

https://gerrit.wikimedia.org/r/1063759

Change #1064067 merged by jenkins-bot:

[design/codex@main] Table: sortable columns inherit font styles

https://gerrit.wikimedia.org/r/1064067

Thanks for filing this bug and working on a solution. @Dogu patch helped me discover that the problem originated in Codex. This patch resolves the Codex bug by setting the font-size and font-family to inherit. You can expect these changes in today's Codex release.

In T372735#10078970, @gerritbot wrote:

Change #1064067 had a related patch set uploaded (by LWatson; author: LWatson):

[design/codex@main] Table: sortable columns inherit font styles

https://gerrit.wikimedia.org/r/1064067

lwatson changed the task status from Open to In Progress.Tue, Aug 20, 6:59 PM

Change #1064134 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v1.11.0 to v1.11.1

https://gerrit.wikimedia.org/r/1064134

Change #1064134 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.11.0 to v1.11.1

https://gerrit.wikimedia.org/r/1064134

egardner subscribed.Wed, Aug 21, 4:33 PM

This comment was removed by egardner.

egardner moved this task from Pending Release to In Progress on the Design-System-Team (DST-Sprint-30 (2024-08-19 to 2024-08-30)) board.Wed, Aug 21, 4:33 PM

egardner updated the task description. (Show Details)Wed, Aug 21, 4:38 PM

egardner closed this task as Resolved.Wed, Aug 21, 4:48 PM

I assume closing this was a misclick based on previous comment.

In T372735#10082520, @Novem_Linguae wrote:

I assume closing this was a misclick based on previous comment.

No, that comment was made in error it turns out. On Beta (where the latest version of Codex is now being used), the font size for that element is correctly set at 14px in the Vector skin. I must have been seeing some cached styles.

Here's a link to the Special:PendingChanges page on Beta: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Special:PendingChanges

Here's a screenshot showing the correct results on Beta:

Screenshot 2024-08-21 at 2.35.57 PM.png (1×1 px, 308 KB)

Versus this screenshot, showing the overly-large text that is still visible in production:

Screenshot 2024-08-21 at 2.36.19 PM.png (1×1 px, 300 KB)

This fix will reach production with the release train tomorrow, so this task can be closed.

egardner closed this task as Resolved.Wed, Aug 21, 9:38 PM

	F57284703: Screenshot 2024-08-21 at 2.36.19 PM.png
	Wed, Aug 21, 9:38 PM

	F57284700: Screenshot 2024-08-21 at 2.35.57 PM.png
	Wed, Aug 21, 9:38 PM

	F57284213: Screenshot 2024-08-21 at 9.32.07 AM.png
	Wed, Aug 21, 4:33 PM

	F57281024: Screenshot 2024-08-19 100938.png
	Mon, Aug 19, 9:10 AM

	F57280970: Screenshot 2024-08-19 100435.png
	Mon, Aug 19, 9:10 AM

	F57280964: Screenshot 2024-08-19 100414.png
	Mon, Aug 19, 9:10 AM

	F57280834: Screenshot 2024-08-19 094854.png
	Mon, Aug 19, 8:49 AM

	F57280761: Screenshot 2024-08-19 093910.png
	Mon, Aug 19, 8:43 AM

Heading of the 'Since' column on Special:PendingChanges has a larger text size than other columnsClosed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions