[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T37053

upload.wikimedia.org should serve a Wikimedia 404 error page when file not found in Swift
Open, MediumPublic
Actions

Description

This is kind of related to T19316, but apparently upload.wikimedia.org is using a separate file, so this gets a separate bug.

The Wikimedia 404 error page was redesigned and synced live to the sites in bug T19316. That redesign apparently didn't hit upload.wikimedia.org.

Example link: https://upload.wikimedia.org/wikipedia/commons/a/a9/NotFound.jpg

Screen Shot 2018-05-01 at 01.44.57.png (434×1 px, 77 KB)

This page is ugly and should be cleaned up to be similar to the "main" 404 error messages at https://en.wikipedia.org/not-found and others.

See also:

Details

Reference
bz35053

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:18 AM
• bzimport added a project: WMF-General-or-Unknown.
• bzimport set Reference to bz35053.
• bzimport added a subscriber: Unknown Object (MLST).
• MZMcBride created this task.Mar 8 2012, 4:57 AM
MarkAHershberger added a comment.Mar 8 2012, 8:17 PM

https://rt.wikimedia.org/Ticket/Display.html?id=2597

Nemo_bis added a comment.Aug 23 2012, 8:35 AM
  • Bug 35722 has been marked as a duplicate of this bug. ***
Krenair edited projects, added acl*sre-team, Traffic; removed WMF-General-or-Unknown.Aug 18 2015, 2:45 AM
Krenair set Security to None.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptAug 18 2015, 2:45 AM
Krenair subscribed.Aug 18 2015, 2:48 AM
• MZMcBride added a project: good first task.Aug 18 2015, 4:17 AM
ori raised the priority of this task from Medium to High.Aug 18 2015, 4:32 AM
ori edited projects, added Blocked-on-Operations; removed good first task.
Dzahn lowered the priority of this task from High to Medium.Sep 16 2015, 10:30 PM
Dzahn subscribed.

I don't see why it became more important now besides that it's a ticket from 2012. The only bug seems to be that it's ugly looking.

That said, is this about a custom nginx error page while the old redesign was about Apache error pages?

faidon renamed this task from upload.wikimedia.org still using old 404 error page to upload.wikimedia.org needs a Wikimedia 404 error page.Sep 17 2015, 6:52 AM
faidon updated the task description. (Show Details)
faidon edited projects, added SRE-swift-storage; removed Blocked-on-Operations, Traffic.
faidon removed a subscriber: • wikibugs-l-list.
faidon subscribed.Sep 17 2015, 6:56 AM

upload requests are being (ultimately) served by Swift, no nginx involved in that layer. Swift doesn't have a mechanism to provide an error page, however it should be possible to write that in a WSGI middleware. The existing staticweb middleware should already have some code that can be borrowed and made generic for global (across containers) error pages.

fgiunchedi added a parent task: T113114: Make all wiki-facing error pages consistent.Jul 19 2017, 3:30 PM
Krinkle mentioned this in T113114: Make all wiki-facing error pages consistent.Jul 21 2017, 10:35 PM
Krinkle subscribed.EditedJul 21 2017, 10:42 PM

Since Thumbor was deployed, 404s for thumbnails now come from Thumbor, which actually doesn't display any error page. But rather, emits an empty response body. Task T169683 is about changing that (probably at the Varnish proxy layer) to instead produce a generic Wikimedia-style 404 page.

However, let's keep this task to only be about the 404s served from Swift for originals.

Krinkle renamed this task from upload.wikimedia.org needs a Wikimedia 404 error page to upload.wikimedia.org should serve a Wikimedia 404 error page when file not found in Swift.Jul 21 2017, 10:43 PM
Krinkle updated the task description. (Show Details)May 1 2018, 12:45 AM
• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits