[go: up one dir, main page]

Page MenuHomePhabricator

[Config] Enable night theme on diff and change list pages
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

As a user I want night them on history and diff pages

User story

As a user I want all my pages in dark mode.

Prerequisites

Requirement

Enable night mode on diff and history pages, as well as on specified special pages, ensuring that all these pages are compatible with the dark theme.

BDD

Feature: Enable Night Mode on Diff and Change List Pages

  Scenario: Enable night mode on diff and history pages
    Given the user has enabled night mode
    When the user visits diff pages (?action=diff) or history pages (?action=history)
    Then the pages should be displayed in night mode without color contrast issues

  Scenario: Enable night mode on specified special pages
    Given the user has enabled night mode
    When the user visits the specified special pages
    Then the pages should be displayed in night mode without color contrast issues

Test Steps

Test Case 1: Verify Night Mode on Diff and History Pages

  1. Enable night mode.
  2. Navigate to the following pages:
  3. AC1: Confirm that the pages display in night mode without color contrast issues.

Test Case 2: Verify Night Mode on Specified Special Pages

  1. Enable night mode.
  2. Navigate to the following special pages:
  3. AC2: Confirm that the pages display in night mode without color contrast issues.

For contributions page

  • The subtask T368680 has been resolved

For diffs

  • Decide whether VisualDiffs is a blocker given it is a beta feature and existing problem (T361468, T368488)

According to Olga and Justin: we are are okay to ship as is, with the understanding these bugs will be addressed soon after the deploy.

For all other pages

  • OOUI supports dark theme
  • The subtask T361717 has been resolved. (1.43.0-wmf.10)
  • The subtask T366920 has been resolved. (1.43.0-wmf.12)
  • The subtask T367438 has been resolved. (1.43.0-wmf.11)
  • The subtask T363878 has been resolved (1.43.0-wmf.11)
  • The subtask T366197 has been resolved (1.43.0-wmf.11)
  • 1.43.0-wmf.12 is everywhere.

Acceptance criteria

Please QA in produciton

Communication criteria - does this need an announcement or discussion?

N/A

Rollback plan

N/A

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - Prod

ACStatusDetails
1T366371#9963869
2T366371#9963869

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from Enable night theme on diff and change list pages to [Config] Enable night theme on diff and change list pages.Jun 13 2024, 4:04 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 1.

All the blockers are now subtasks. Moving this to "Ready" under assumption this would be a config change when all those issues have been resolved and is a 1 pointer.

ovasileva lowered the priority of this task from High to Medium.Jun 20 2024, 4:56 PM
Jdlrobson updated the task description. (Show Details)

Change #1049975 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

https://gerrit.wikimedia.org/r/1049975

Okay this should be ready for deploy on 4th July onwards.

Change #1049975 abandoned by Jdlrobson:

[operations/mediawiki-config@master] Enable action edit/submit and remaining special pages in dark mode (1.43.0-wmf.12)

Reason:

Moved into https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1050671?usp=search

https://gerrit.wikimedia.org/r/1049975

Jdlrobson changed the task status from Stalled to Open.Jul 1 2024, 10:05 PM

Still stalled, but I'll use blocked on others to reflect the current state - we're waiting for the train to roll out before enabling these pages!

Seems like unpatrolled edits lack Codex-tokens for background styling.

image.png (606×1 px, 229 KB)

@Sjoerddebruin how do I get that highlighting? Is it a gadget or part of FlaggedRevisions? I can't seem to find the associated CSS but would like to create a new phabricator ticket!

@Sjoerddebruin how do I get that highlighting? Is it a gadget or part of FlaggedRevisions? I can't seem to find the associated CSS but would like to create a new phabricator ticket!

MediaWiki-Patrolling i would assume, it's the default patrolling in MediaWiki. The CSS tag is .not-patrolled.

ovasileva raised the priority of this task from Medium to High.Jul 8 2024, 10:54 AM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: GMikesell-WMF.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Night Mode on Diff and History Pages

  1. Enable night mode.
  2. Navigate to the following pages:
  3. AC1: Confirm that the pages display in night mode without color contrast issues.

screenshot 115.png (1×1 px, 464 KB)

screenshot 116.png (1×1 px, 154 KB)

Test Case 2: Verify Night Mode on Specified Special Pages

  1. Enable night mode.
  2. Navigate to the following special pages:
  3. AC2: Confirm that the pages display in night mode without color contrast issues.

screenshot 117.png (1×1 px, 225 KB)

screenshot 118.png (1×1 px, 503 KB)

screenshot 119.png (1×1 px, 180 KB)

screenshot 120.png (1×1 px, 164 KB)

screenshot 121.png (1×1 px, 435 KB)

screenshot 122.png (1×1 px, 138 KB)

screenshot 123.png (1×1 px, 137 KB)

ovasileva claimed this task.