[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T348724

Update sonar scanner node version from v14 to v16
Closed, ResolvedPublic
Actions

Description

Sonar scanner is currently using v14 node version which is now deprecated. This should be updated to use v16

node_version.png (156×3 px, 65 KB)

Auth: 'sonar.login' property is now deprecated and should be changed to 'sonar.token'
token.png (100×2 px, 34 KB)

Details

SubjectRepoBranchLines +/-
jjb: Update sonar-scanner uses to images with node16 not node14integration/configmaster+2 -2
dockerfiles: [sonar-scanner] Upgrade nodejs from node14 to node16integration/configmaster+16 -47
Customize query in gerrit

Related Objects

Event Timeline

pwangai created this task.Oct 12 2023, 9:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2023, 9:28 AM
pwangai claimed this task.Oct 12 2023, 9:28 AM
pwangai attached a referenced file: F38215025: node_version.png. (Show Details)
pwangai moved this task from Inbox to SonarCloud Admin on the Quality-and-Test-Engineering-Team board.
pwangai edited projects, added Quality-and-Test-Engineering-Team (SonarCloud Admin); removed Quality-and-Test-Engineering-Team.
pwangai changed the task status from Open to In Progress.Oct 12 2023, 9:31 AM
gerritbot added a comment.Oct 12 2023, 11:42 AM

Change 965502 had a related patch set uploaded (by Pwangai; author: Pwangai):

[integration/config@master] dockerfiles: [sonar-scanner] Upgrade nodejs from node14 to node16

https://gerrit.wikimedia.org/r/965502

gerritbot added a project: Patch-For-Review.Oct 12 2023, 11:42 AM
gerritbot added a comment.Oct 12 2023, 1:05 PM

Change 965502 merged by jenkins-bot:

[integration/config@master] dockerfiles: [sonar-scanner] Upgrade nodejs from node14 to node16

https://gerrit.wikimedia.org/r/965502

Stashbot added a comment.Oct 12 2023, 1:06 PM

Mentioned in SAL (#wikimedia-releng) [2023-10-12T13:06:43Z] <hashar> Updating docker-pkg files for https://gerrit.wikimedia.org/r/c/integration/config/+/965502 # T348724

Maintenance_bot removed a project: Patch-For-Review.Oct 12 2023, 1:10 PM
gerritbot added a comment.Oct 12 2023, 2:24 PM

Change 965523 had a related patch set uploaded (by Pwangai; author: Pwangai):

[integration/config@master] jjb: Update sonar-scanner uses to images with node16 not node14

https://gerrit.wikimedia.org/r/965523

gerritbot added a project: Patch-For-Review.Oct 12 2023, 2:24 PM
Stashbot added a comment.Oct 12 2023, 2:47 PM

Mentioned in SAL (#wikimedia-releng) [2023-10-12T14:47:31Z] <hashar> Update code health jobs to NodeJS 16 | https://gerrit.wikimedia.org/r/c/integration/config/+/965523/ | T348724

gerritbot added a comment.Oct 12 2023, 2:49 PM

Change 965523 merged by jenkins-bot:

[integration/config@master] jjb: Update sonar-scanner uses to images with node16 not node14

https://gerrit.wikimedia.org/r/965523

pwangai closed this task as Resolved.Oct 12 2023, 3:00 PM
pwangai mentioned this in T347810: sonarcloud.io deprecation warnings.
Maintenance_bot removed a project: Patch-For-Review.Oct 12 2023, 3:10 PM
Jdforrester-WMF subscribed.Oct 13 2023, 12:33 PM

Should this image inherit from our standard node16 image so that it gets "automatically" updated when we migrate node version?

pwangai added a comment.Oct 17 2023, 8:41 AM

Sonar can use any node version as long as its not a deprecated version. Inherit from our standard node16 image seems like the most optimal way to go :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits