[go: up one dir, main page]

Page MenuHomePhabricator

Returning back from the "Away" status, I don't get newcomers assigned to me
Closed, ResolvedPublic4 Estimated Story PointsBUG REPORT

Description

Steps to reproduce at Special:MentorDashboard

  1. The Number of mentees assigned to me is not set to "None (I claim them manually)"
  2. Set the Mentor status as Away
  3. Fill the date field
  4. Wait for that date
  5. Check your status on the Mentor dashboard

Expectations:

  • your status is "Active"
  • The number of mentees assigned to me is set to "None (I claim them manually)"

Expectations:

  • your status is "Active"
  • the number of mentees assigned to me is what was chosen before

Tested on my personal account at French Wikipedia. I haven't found any similar reports, so it might be unique due to my settings/gadgets/scripts.

Event Timeline

@Trizek-WMF - thx for reporting the issue! There were some discrepancies before between the mentor status and the number of mentees assigned ( e.g. the selected settings wouldn't stick, not possible to select some specific combination of settings etc).
I'm checking it in testwiki (and in betalabs and will provide updates to this ticket as soon as possible.

Very good catch, @Trizek-WMF! This is an interesting bug. It can be reproduced "on demand" by first setting your mentorship state to "Away" and then running new mw.Api().saveOption('growthexperiments-mentor-away-timestamp', '20210101000000') in the console (any date in the past should work).

Urbanecm_WMF changed the subtype of this task from "Task" to "Bug Report".

This can be reasonably fixed with the T347157: Structured mentor list: Migrate `autoAssigned` into weight maintenance piece of work. I think we should do both :)).

Change 960070 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Structured mentor list: Make "no mentees" a proper weight

https://gerrit.wikimedia.org/r/960070

@Trizek-WMF - thx for reporting the issue! There were some discrepancies before between the mentor status and the number of mentees assigned ( e.g. the selected settings wouldn't stick, not possible to select some specific combination of settings etc).
I'm checking it in testwiki (and in betalabs and will provide updates to this ticket as soon as possible.

Although there is already a patch (thx, @Urbanecm_WMF!), I am adding here a confirmed current behavior on`testwiki wmf.27` and betalabs - the status Away is successfully changed back Active after a time interval set by a mentor is done. Number of mentees assigned to me falls to "None (I claim them manually)", disregarding the settings before Away status was set.

Hi @KStoller-WMF, I think T347436 is a separate bug, not a dupe of this
task. In this task, the issue happens when a mentor *returns* (their weight
is changed to None). In the other task, the issue happens when an admin
makes another mentor away until a date that's in the past (the save will be
"successful", but nothing would happen). I'd say the other task is a less
significant bug, as it doesn't seem to be breaking something, while this
task should be finished ASAP.

Thanks for the explanation! I've re-opened T347436.

Change 960070 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured mentor list: Make "no mentees" a proper weight

https://gerrit.wikimedia.org/r/960070

Urbanecm_WMF set the point value for this task to 4.Nov 5 2023, 1:35 AM

Change 971533 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.3] Structured mentor list: Make "no mentees" a proper weight

https://gerrit.wikimedia.org/r/971533

Change 971533 merged by Urbanecm:

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.3] Structured mentor list: Make "no mentees" a proper weight

https://gerrit.wikimedia.org/r/971533

Mentioned in SAL (#wikimedia-operations) [2023-11-06T08:01:46Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:971533|Structured mentor list: Make "no mentees" a proper weight (T347157 T347024)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-06T08:14:00Z] <urbanecm@deploy2002> urbanecm: Backport for [[gerrit:971533|Structured mentor list: Make "no mentees" a proper weight (T347157 T347024)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-06T08:25:23Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:971533|Structured mentor list: Make "no mentees" a proper weight (T347157 T347024)]] (duration: 23m 37s)

Should not happen anymore (in both beta and production).

Should not happen anymore (in both beta and production).

Checked in testwiki wmf.5 - the issue has been fixed; the mentor's "Number of mentees assigned to me" is the same as a mentor defined before marking their status as "Away".