[go: up one dir, main page]

Page MenuHomePhabricator

Responsive adjustments and styling for Contribute persistent entry point
Closed, ResolvedPublic

Assigned To
Authored By
Pginer-WMF
Oct 25 2022, 11:11 AM
Referenced Files
F37784623: contribute_entry_point.webm
Sep 26 2023, 3:11 AM
Restricted File
Nov 3 2022, 9:55 AM
F35701253: image.png
Nov 3 2022, 9:54 AM
F35701259: image.png
Nov 3 2022, 9:54 AM
F35701238: image.png
Nov 3 2022, 9:54 AM
F35701231: image.png
Nov 3 2022, 9:54 AM
Tokens
"Love" token, awarded by Jdlrobson.

Description

The initial version of the "Contribute" persistent entry point is available (T286466). This ticket proposes responsive adjustments and styling to better integrate the menu in the different mobile and desktop contexts.

Below is the current status on mobile (English and Bengali) and Desktop (English and Bengali) on the beta cluster, and the proposed adjustments.

Current Mobile (bn)Current Desktop (bn)Proposed Mobile (en)Proposed Desktop (en)
bn.m.wikipedia.beta.wmflabs.org_wiki_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_Contribute_Cronopio(iPhone SE).png (1×750 px, 119 KB)
bn.wikipedia.beta.wmflabs.org_wiki_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_Contribute.png (779×1 px, 112 KB)
Mobile.png (1×320 px, 56 KB)
Desktop.png (900×1 px, 71 KB)

More details below about the specific changes proposed.

Adjustments for wider screens

  • Two cards per row on wider screens. On Desktop and Tablet, the options to contribute will be displayed showing two on each row with a separation of 24px between cards (and 32px distance to the edges).

Desktop-sizing-spec.png (547×1 px, 49 KB)

CurrentProposed
en.wikipedia.beta.wmflabs.org_wiki_Special_Contribute.png (712×1 px, 86 KB)
Desktop.png (900×1 px, 71 KB)

Based on the breakpoint proposal (T303522), this applies to:

  • @min-width-breakpoint-desktop-wide 1680px and more
  • @min-width-breakpoint-desktop 1120px - 1679px
  • @min-width-breakpoint-tablet 640px - 1119px

Adjustments for narrow screens

  • Edge-to-edge background on mobile. Cards are displayed on a grey background, on mobile this background has some additional margin that makes it look like a grey box on a white background. Making the margin to be 0px solves the issue as illustrated below.
CurrentProposed
bn.m.wikipedia.beta.wmflabs.org_wiki_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_Contribute(iPhone SE) (1).png (667×375 px, 76 KB)
bn.m.wikipedia.beta.wmflabs.org_wiki_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%87%E0%A6%B7_Contribute(iPhone SE).png (667×375 px, 75 KB)
  • Avoid extra space below last card. On mobile the intended spacing between cards is 24px vertically and 16px of spacing to the sides. The current implementation follows this, however additional space is added at the bottom of the last card that should be removed.

Mobile-sizing-spec.png (587×380 px, 35 KB)

Based on the breakpoint proposal (T303522), this applies to:

  • @min-width-breakpoint-mobile 320px - 639px

Adjustments for all screens

  • Use a lighter grey for card background. Initially Base80 (#eaecf0) was proposed for the background of cards but the lighter Base90 (#f8f9fa) is preferred instead to better align it with the side menu on desktop.
  • Add border to the cards. A border will help better distinguish cards once the lighter background is used. The border will be 1px border using Base70 (#C8CCD1) or "border-subtle" token for color.
CurrentProposed
en.wikipedia.beta.wmflabs.org_wiki_Special_Contribute (2).png (689×1 px, 111 KB)
en.wikipedia.beta.wmflabs.org_wiki_Special_Contribute (1).png (689×1 px, 111 KB)
  • Make action link bold and increase spacing. The action in blue shown at the bottom of the text can benefit from some adjustments to make it more clear: adjust font weight to bold and 4px of space above it.
CurrentProposed
en.m.wikipedia.beta.wmflabs.org_wiki_Special_Contribute(iPhone SE) (1).png (667×375 px, 54 KB)
en.m.wikipedia.beta.wmflabs.org_wiki_Special_Contribute(iPhone SE) (2).png (667×375 px, 55 KB)

Event Timeline

Pginer-WMF created this task.

Change 852742 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/core@master] Special:Contribute: Responsive adjustments and styling

https://gerrit.wikimedia.org/r/852742

Screenshots after the patch:
Desktop- For testing I just duplicated the cards using browser dev tools:

Wide screenNarrow screen
image.png (815×867 px, 72 KB)
image.png (928×673 px, 64 KB)

Mobile:

Wide screenNarrow screen
image.png (544×1 px, 37 KB)
{F35701268 size=full}

@Pginer-WMF, eventhough T303522 has decisions on breakpoints, it is initially available only at Codex. This interface we are customizing does not use Codex. So we will have to rely to existing definitions of breakpoints in mediawiki core. But whenever those definitions are updated, Special:Contribute will reflect those changes automatically.

Change 852742 merged by jenkins-bot:

[mediawiki/core@master] Special:Contribute: Responsive adjustments and styling

https://gerrit.wikimedia.org/r/852742

@Pginer-WMF, eventhough T303522 has decisions on breakpoints, it is initially available only at Codex. This interface we are customizing does not use Codex. So we will have to rely to existing definitions of breakpoints in mediawiki core. But whenever those definitions are updated, Special:Contribute will reflect those changes automatically.

Sounds good. Thanks for the heads-up, Santhosh.

Test Status: QA PASS

For Desktop, mobile ( wide and narrow. )