The nearby layer vanishes when collapsing the map and is still gone when expanding, but the button is still marked as active.
The button should reset as soon as the map is collapsed.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Reset "show nearby articles" button state on close | mediawiki/extensions/Kartographer | master | +6 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T90645 A better Nearby for Wikivoyage | |||
| Open | None | T304076 Nearby feature for maps | |||
| Resolved | thiemowmde | T316217 Nearby button still marked active when collapsing and reopening the map |
Event Timeline
Comment Actions
I would like some UX expertise on the question if we should simply reset the button or maybe do something else. Because the current behaviour for other actions is to keep the user actions. If you for example move the map around, close the full screen view and open it back up again, the map shows the last area and not the one from the start. Same thing happens with the other button in the footer (the external maps icon). That also displays the last state after closing and reopening. Only reloading the page does reset both. Deactivating the nearby button and not showing the nearby points after closing the map would than be different from these two behavious. Is that what we want, @ECohen_WMDE? I added a screencast to our meeting notes (too big for phabricator it seems).
Comment Actions
Change 826947 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Kartographer@master] Reset "show nearby articles" button state on close
Comment Actions
Change 826947 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Reset "show nearby articles" button state on close