[go: up one dir, main page]

Page MenuHomePhabricator

Make sure that the nearby feature can be tested on beta
Closed, ResolvedPublic2 Estimated Story Points

Description

Currently data on the beta cluster is not very helpful when testing the nearby feature. Several reasons for that:

  • There are not many articles with primary coordinates like

{{#coordinates:43.731111|7.42|primary}}

  • The icons on the map added by the feature are broken

Screenshot 2022-08-10 at 12-08-00 Maptests - Wikipedia the free encyclopedia.png (126×157 px, 28 KB)

Event Timeline

The marker icons seem to be broken because protocol-relative links are generated, but to an external site: "//api.tiles.mapbox.com/mapbox.js/v3.3.1/images/marker-icon.png" . It would need to be "https://". However, we should be pulling the icon from the local kartotherian service either way, so we'll need to override the marker URL entirely. The image should be something like https://maps-beta.wmflabs.org/v4/marker/pin-l-marker+f00.png

The URL is coming from leaflet/src/layer/marker/Icon.Default.js and it looks like it's designed to be overridden by an Icon constructor option.

The marker icons seem to be broken because protocol-relative links are generated, but to an external site: "//api.tiles.mapbox.com/mapbox.js/v3.3.1/images/marker-icon.png" . It would need to be "https://". However, we should be pulling the icon from the local kartotherian service either way, so we'll need to override the marker URL entirely. The image should be something like https://maps-beta.wmflabs.org/v4/marker/pin-l-marker+f00.png

The URL is coming from leaflet/src/layer/marker/Icon.Default.js and it looks like it's designed to be overridden by an Icon constructor option.

See T315039: Layer to show nearby features uses mapbox.com imagePath

Change 822616 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Add custom styling for nearby markers

https://gerrit.wikimedia.org/r/822616

Change 822616 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Add custom styling for nearby markers

https://gerrit.wikimedia.org/r/822616

Most annoying broken issue got fixed. It seems we have indeed a few articles at least. Considering this done.

WMDE-Fisch claimed this task.
WMDE-Fisch set the point value for this task to 2.