[go: up one dir, main page]

Page MenuHomePhabricator

Launch visual diffs on history pages out of beta and provide it to all users
Closed, ResolvedPublic

Description

It's been a Beta Feature for years without significant change (which normally would mean it should have been discontinued). The product works quite well (and would have been somewhat helpful with a big media story last week, for instance).

The performance impact of enabling this for readers is trivial until the user clicks the "visual" button, which I don't propose to make default yet.

When the long-planned multiple-diff-tools project (to provide single-column diff on desktop etc.) happens this could plug into that, but let's just get it out there?

September 2022 plan

  • Default "on" for everyone at the wiki (=adds a switching button to diff pages)
  • Default to "wikitext" for everyone (it's a sticky pref, so whatever you used last time is what you'll get next time)
  • Not Wiktionaries (templates) or Wikipedias (scale/size) during the first round

March 2023 plan

  • Default "on" for everyone
  • Default to "wikitext" for everyone who hasn't used it before
  • Wiktionaries (where it will probably not get much use) and Wikipedias (may be split into multiple deployments because of scale/size)

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

NB this is just for history pages. Visual diffs have been enabled in VE by default for a long time. I agree this is pretty low risk, the default is still wikitext and this will just show a switcher in the top right.

Jdforrester-WMF renamed this task from Launch visual diffs out of beta and provide it to all users to Launch visual diffs on history pages out of beta and provide it to all users.Aug 5 2022, 4:23 PM

Change 820840 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Enable visual diffs on history pages by default

https://gerrit.wikimedia.org/r/820840

Notes:

  • [ACTION] @ppelberg to decide on deployment date/place
  • [CONFIRMED] When visual diffs are made available by default, people experience the following:
    • 1) An addition Visual toggle would be appear within the diff view [i]
    • 2) If/when people clicked/tapped the Visual toggle, the next time they view a diff, that diff will default to the Visual view until they elect to view the Wikitext view at which their invisible preference would be updated

Notes:

  • [ACTION] @ppelberg to decide on deployment date/place
  • We're going to offer visual diffs as a default-on feature at all sisters project except all wiktionaries.
  • Note: the default diff view should remain wikitext

Q.1: Will this be default-on at Wikipedias, too?
The comment above says "a default-on feature at all sisters project except all wiktionaries",
whereas the draft Tech News entry says "Visual diffs will become available to all users, except at the Wiktionaries and Wikipedias. [1]"
I'm unsure whether that entry is an accurate.
(Clarified per update below)

Q.2. Perhaps it would be useful to put an explanation in this task's Description (for anyone curious who clicks thru from Tech News) about why it isn't available at Wiktionaries (and Wikipedias, if applicable) ? (Done, TY WAID!)

Change 833831 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[operations/mediawiki-config@master] Enable history page visual diffs on beta cluster

https://gerrit.wikimedia.org/r/833831

Change 833831 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable history page visual diffs on beta cluster

https://gerrit.wikimedia.org/r/833831

Mentioned in SAL (#wikimedia-operations) [2022-11-08T21:08:27Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:833831|Enable history page visual diffs on beta cluster (T314588)]], [[gerrit:851132|Update wgSpecialContributeSkinsDisabled → wgSpecialContributeSkinsEnabled (T319327)]]

Mentioned in SAL (#wikimedia-operations) [2022-11-08T21:13:00Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:833831|Enable history page visual diffs on beta cluster (T314588)]], [[gerrit:851132|Update wgSpecialContributeSkinsDisabled → wgSpecialContributeSkinsEnabled (T319327)]] (duration: 04m 33s)

Change 888804 had a related patch set uploaded (by Esanders; author: Esanders):

[operations/mediawiki-config@master] Enable history page visual diffs every except Wikipedias and Wiktionaries

https://gerrit.wikimedia.org/r/888804

Change 820840 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Enable visual diffs on history pages by default

https://gerrit.wikimedia.org/r/820840

Change 888804 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable history page visual diffs everywhere except Wikipedias and Wiktionaries

https://gerrit.wikimedia.org/r/888804

Mentioned in SAL (#wikimedia-operations) [2023-03-08T21:29:06Z] <kindrobot@deploy2002> Started scap: Backport for [[gerrit:888804|Enable history page visual diffs everywhere except Wikipedias and Wiktionaries (T314588)]], [[gerrit:895375|Release DiscussionTools on mobile on enwiki (T328942)]], [[gerrit:895297|Switch order of "Add topic" and language dropdown (T267444)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-08T21:30:46Z] <kindrobot@deploy2002> kemayo and kindrobot and esanders: Backport for [[gerrit:888804|Enable history page visual diffs everywhere except Wikipedias and Wiktionaries (T314588)]], [[gerrit:895375|Release DiscussionTools on mobile on enwiki (T328942)]], [[gerrit:895297|Switch order of "Add topic" and language dropdown (T267444)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug1001.eqi

Mentioned in SAL (#wikimedia-operations) [2023-03-08T21:46:51Z] <kindrobot@deploy2002> Started scap: Backport for [[gerrit:895297|Switch order of "Add topic" and language dropdown (T267444)]], [[gerrit:895375|Release DiscussionTools on mobile on enwiki (T328942)]], [[gerrit:888804|Enable history page visual diffs everywhere except Wikipedias and Wiktionaries (T314588)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-08T21:48:45Z] <kindrobot@deploy2002> kemayo and kindrobot and esanders: Backport for [[gerrit:895297|Switch order of "Add topic" and language dropdown (T267444)]], [[gerrit:895375|Release DiscussionTools on mobile on enwiki (T328942)]], [[gerrit:888804|Enable history page visual diffs everywhere except Wikipedias and Wiktionaries (T314588)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.cod

Mentioned in SAL (#wikimedia-operations) [2023-03-08T21:54:40Z] <kindrobot@deploy2002> Finished scap: Backport for [[gerrit:895297|Switch order of "Add topic" and language dropdown (T267444)]], [[gerrit:895375|Release DiscussionTools on mobile on enwiki (T328942)]], [[gerrit:888804|Enable history page visual diffs everywhere except Wikipedias and Wiktionaries (T314588)]] (duration: 07m 49s)

This is now launched everywhere but Wikipedias and Wiktionaries, and we should presumably decide when we want to launch it there. (I guess if no terrible issues develop in the next few weeks.)

Wikipedias (may be split into multiple deployments because of scale/size)

@Whatamidoing-WMF Do you have a list of specific wikis to deploy to, and when?

@Esanders, I have no strong views on how to divide it, or even if it needs to be divided. The English Wikipedia is half of traffic, though, so if there is any concern from an SRE viewpoint, then putting "enwiki" and "everyone else" in different buckets would be an easy way to spread things out. But if there's no technical concern, then they could all be done at once, at any time, as far as I'm concerned.

Change 903780 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[operations/mediawiki-config@master] Enable history page visual diffs on remaining wikis

https://gerrit.wikimedia.org/r/903780

Change 903780 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable history page visual diffs on remaining wikis

https://gerrit.wikimedia.org/r/903780

Mentioned in SAL (#wikimedia-operations) [2023-03-29T13:08:44Z] <lucaswerkmeister-wmde@deploy2002> Started scap: Backport for [[gerrit:903780|Enable history page visual diffs on remaining wikis (T314588)]]

Mentioned in SAL (#wikimedia-operations) [2023-03-29T13:10:09Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde and matmarex: Backport for [[gerrit:903780|Enable history page visual diffs on remaining wikis (T314588)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-03-29T13:17:08Z] <lucaswerkmeister-wmde@deploy2002> Finished scap: Backport for [[gerrit:903780|Enable history page visual diffs on remaining wikis (T314588)]] (duration: 08m 23s)

Just got this update! Thanks, all of you who worked on it, it's quite useful!

I am struggling to understand why I don’t see any option to disable this feature in user preferences. (Personally, I want to do so because it adds more meaningless cruft into diff URL when there’s already more than enough as it is if you want a clean diff link, but people might do it for different reasons.) Can someone add that if this was an oversight?

On-wiki discussion in Russian Wikipedia where people are asking for the same: https://ru.wikipedia.org/wiki/Википедия:Форум/Технический#«Визуальный»_«Вики-текст»

I also don't understand the rationale for forcing this feature to those who are not using VisualEditor. I understand it may make sense for a person already uses Visual editor and now wants to check their diffs on the fly with the classic wikitext source, but that's not applicable if one already uses wikitext by default. It just adds clutter for a feature that's meant to stick indefinately across sessions and to people who explicitly disabled Visual editor (and visual diffs by extension).

T333756 brought me here.

From my side, visual diffs have only downsides (and important ones: slow loading, usability close to zero) compared to regular diffs.
Though, I understand the desire to provide a visual, rather than code, experience to widespread users.

So I'm just hiding the toggle using personal CSS.

I just hope the visual diffs will never, ever be loaded by default.
But if sadly, it became the case, that a user preference will be provided to disable them.

A minor annoyance though: when viewing a diff page, &diffmode=source gets dynamically appended to the query string. It lengthen these URLs, which are often posted/shared.

The append is made precisely here: ve.init.mw.DiffPage.init.js#L97-L98. It has been introduced in commit 1d70266.

And see below, in ve.init.mw.DiffPage.init.js#L126-L129:

select is emitted even when the mode is set programmatically (e.g. on load)

My understanding is that the parameter is intended to be appended to the query string when using the toggle (which is fine obviously), but an undesirable side-effect is that the parameter also gets appended on page load.

@Od1n

A minor annoyance though: when viewing a diff page, &diffmode=source gets dynamically appended to the query string. It lengthen these URLs, which are often posted/shared.

There's T213522 for changing this behavior, if you want to provide feedback about use-cases there.

Change 1011446 had a related patch set uploaded (by Etetetet; author: Etetetet):

[mediawiki/extensions/VisualEditor@master] Revert "Enable visual diffs on history pages by default"

https://gerrit.wikimedia.org/r/1011446

Change 1011446 abandoned by Esanders:

[mediawiki/extensions/VisualEditor@master] Revert "Enable visual diffs on history pages by default"

Reason:

https://gerrit.wikimedia.org/r/1011446

Change #1011446 restored by Etetetet:

[mediawiki/extensions/VisualEditor@master] Revert "Enable visual diffs on history pages by default"

https://gerrit.wikimedia.org/r/1011446

Change #1011446 abandoned by Esanders:

[mediawiki/extensions/VisualEditor@master] Revert "Enable visual diffs on history pages by default"

Reason:

Please do not restore commits that have been abandoned for a good reason.

https://gerrit.wikimedia.org/r/1011446