[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T313127

Disable $wgLegacyJavaScriptGlobals on all wikis
Closed, InvalidPublic
Actions

Description

$wgLegacyJavaScriptGlobals is false per default, and per the documentation there should be no need for it to be true. It's also disabled for mobile page views. Can we disable it for everything?

Related Objects

Event Timeline

daniel created this task.Jul 15 2022, 2:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2022, 2:26 PM
Krinkle edited projects, added Wikimedia-Site-requests; removed MediaWiki-Configuration.Jul 15 2022, 3:51 PM
Krinkle added a comment.Jul 15 2022, 3:56 PM

Define "everything"? It appears to be false everywhere that we control and has also been removed as a feature in RL already several releases ago.

T72470: Remove legacy javascript globals
T35837: Set $wgLegacyJavaScriptGlobals = false by default

https://codesearch.wmcloud.org/search/?q=LegacyJavaScriptGlobals

daniel added a comment.Jul 15 2022, 8:28 PM
In T313127#8081008, @Krinkle wrote:

Define "everything"? It appears to be false everywhere that we control and has also been removed as a feature in RL already several releases ago.

Appologies - filed this in a rush, and got the wrong setting. I meant $wgIncludeLegacyJavaScript. I will file a new task, to avoid confusion: T313139: Disable $wgIncludeLegacyJavaScript on all wikis

Krinkle closed this task as Invalid.Jul 15 2022, 8:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits