[go: up one dir, main page]

Page MenuHomePhabricator

Always show AMC mode of contributions page to mobile users
Closed, ResolvedPublic3 Estimated Story Points

Description

After discussion with Olga and Alex, we've decided to show the AMC mode page to all users in mobile.

In future, we (or others) can explore improving the AMC design to incorporate the useful elements of the mobile version, namely introducing section headings.

Checklist

  • The MFUseDesktopContributionsPage configuration flag is removed from MobileFrontend.
  • The associated ServiceWiring features are removed.
  • The README.md is updated to exclude the configuration flag
  • The hook Hooks::onSpecialPageInitList is updated so that the desktop contributions page is never overriden.
  • The SpecialMobileContributions class has been removed from MobileFrontend
  • Remove tests/phpunit/specials/SpecialMobileContributionsTest.php
  • Create a patch /task to update mediawiki-config when it is safe to do so, so that MFUseDesktopContributionsPage is never utilized. >> T300583

Event Timeline

Jdlrobson created this task.

Change 758567 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/MobileFrontend@master] Always show AMC mode of contributions page to mobile users

https://gerrit.wikimedia.org/r/758567

cjming updated the task description. (Show Details)
cjming moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.
Jdlrobson added a subscriber: Alex.

Hi @Alex I'm going to merge this one first thing tomorrow to allow you some additional time to test. I've created a patch demo for testing above so you have a bit of a head start.

This would be a good opportunity to:

  1. open new tasks for anything we want to later consider carrying over from the old mobile design e.g. section headings / better visual scanning of information.
  2. fix any bugs given we will be showing this page to more people now.

https://patchdemo.wmflabs.org/wikis/1f8a4ddb53/w/index.php?title=Special:Contributions/Maintenance_script&mobileaction=toggle_view_mobile

Change 758567 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Always show AMC mode of contributions page to mobile users

https://gerrit.wikimedia.org/r/758567

given T293268 and recent discussions I think it would make most sense to create a new task with any future changes we plan to make

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/1f8a4ddb53/w/