[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T286777

Add tags support to RepoApi
Closed, ResolvedPublic
Actions

Description

RepoApi (lib/resources/wikibase-api/src/RepoApi.js) is used to make Wikibase edits from JavaScript. To implement several parts of T236893, we need to add support for edit tags to it.

Details

SubjectRepoBranchLines +/-
Add tags to RepoApiwikibase/javascript-apimaster+68 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 16 2021, 11:24 AM
Lucas_Werkmeister_WMDE added a parent task: T286773: Tag edits made via Wikibase View.

I can see two approaches:

  1. Add a tags parameter to the methods that make edits: editEntity, setLabel, etc.
  2. Add a tags parameter to the constructor, and use that for all edits made by the instance.

The second one seems much more elegant to me, and it probably also means we have to do less work to propagate the tags configuration: just configure the tags when the RepoApi is created, and then pass around the instance as usual.

Lucas_Werkmeister_WMDE added a subtask: T286778: Add tags parameter to wbmergeitems API.Jul 16 2021, 11:35 AM

Turns out one of the APIs exposed by RepoApi doesn’t even have a tags parameter yet: T286778: Add tags parameter to wbmergeitems API

• Manuel subscribed.Jul 20 2021, 10:14 AM
Lucas_Werkmeister_WMDE claimed this task.Jul 22 2021, 2:05 PM
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jul 22 2021, 3:17 PM

Change 706514 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[wikibase/javascript-api@master] Add tags to RepoApi

https://gerrit.wikimedia.org/r/706514

gerritbot added a project: Patch-For-Review.Jul 22 2021, 3:17 PM
Lucas_Werkmeister_WMDE added a comment.Jul 22 2021, 4:01 PM

Probably blocked on T287178: Fix Wikibase JavaScript API (RepoApi) build / CI (unless we think this is important enough for a force-merge).

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 23 2021, 1:54 PM
Addshore closed subtask T286778: Add tags parameter to wbmergeitems API as Resolved.Jul 26 2021, 12:48 PM
gerritbot added a comment.Jul 26 2021, 1:04 PM

Change 706514 merged by jenkins-bot:

[wikibase/javascript-api@master] Add tags to RepoApi

https://gerrit.wikimedia.org/r/706514

Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 26 2021, 1:07 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Let’s call this done, we’ll see in the parent tasks if it works or not.

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2021, 1:10 PM
Ladsgroup subscribed.Jul 26 2021, 1:12 PM
In T286777#7236131, @Lucas_Werkmeister_WMDE wrote:

Let’s call this done, we’ll see in the parent tasks if it works or not.

Shouldn't we update the submodule? :D

Lucas_Werkmeister_WMDE added a comment.Jul 26 2021, 1:15 PM

Well yes, that’ll be part of the parent tasks IMO :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits