[go: up one dir, main page]

Page MenuHomePhabricator

Reference Previews breaks CiteTooltip on he.wikipedia.org
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to reproduce:

  • Log in as a registered user on he.wikipedia.org
  • Enable the Reference Previews beta feature
  • Enable the CiteTooltip gadget (default setting is true)
  • View an article page
  • Hover over a footnote link

You won't see anything. Correct behavior would be that CiteTooltip appears. Reference Previews is accurately disabling itself due to the gadget conflict, but is still somehow damaging whatever CiteTooltip does. Disabling the reference previews beta feature causes CiteTooltip to appear again.

This should be fixed before we go to default, or at least we need to determine whether the default setting will break CiteTooltip for everyone.

Event Timeline

awight changed the subtype of this task from "Task" to "Bug Report".Mar 3 2021, 12:26 PM

Update: we suspect that once we go out of beta mode, then reference previews will disable itself when CiteTooltip is enabled, and the tooltips will correctly appear.

The gadget's code sits here [1]

The gadget seems to be triggered by the user setting for the BetaFeatures and not by code that might be executed.

mw.user.options.get('popupsreferencepreviews') != '1' [2]

We definitely need to look at this again if eventually leave beta for he.wikipedia. The setting that triggers Reference Previews will be different then, but the original betafeature setting will still be in the DB I guess.

[1] https://he.wikipedia.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Gadget-CiteTooltip.js
[2] https://he.wikipedia.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Gadget-CiteTooltip.js#L-3

thiemowmde added subscribers: Lena_WMDE, thiemowmde.

Uh, this is really cool. This is the first wiki that intentionally disabled their (default!) gadget in favor of our feature. The relevant change was made in December 2019: https://he.wikipedia.org/wiki/Special:Diff/26873772.

We missed that when we made our list at https://docs.google.com/spreadsheets/d/1JfkqvdhqrT7gXb1pDKWhqE2yaV-HcZe9pH4VGyJtoTs. I updated the list to reflect this new finding. I also checked all other wikis that use the same CiteTooltip gadget. But this is the only one that was modified so far.

Note that T276330 is only a temporary fix as long as the feature is in Beta on this wiki, as already mentioned above. The moment we are not in Beta any more, we must either add our exclusion back, or ask the gadget author to update their script again.

Next step: Message the user and ask if they can update the gadget to include both the old as well as the new setting name popups-reference-previews (see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/682926/2/src/isReferencePreviewsEnabled.js#36).

thiemowmde set the point value for this task to 1.Apr 28 2021, 8:44 AM

I posted a request on the user page of the user that appears to be the main author/maintainer of the gadget: https://he.wikipedia.org/wiki/Special:Diff/31276698. Let's wait a few days for a response now, but ideally not longer than May 5th, see T271206. Alternatively we could contact one of the other users that edited the page.