[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T267925

Allow displaying URL shortener link in sidebar for foreign wiki
Closed, ResolvedPublic
Actions

Description

In T267921: Roll out the Toolbox link for URL Shortener in Wikimedia sites, @patilise asked for the sidebar link (implemented as T107101) to be enabled at all Wikimedia wikis. However, as I explained at T267921#6623871, in the current form of the code, $wgUrlShortenerReadOnly needs to be false in order for the sidebar to display. In Wikimedia wikis, that variable is set to true at all wikis but metawiki, in order for throttling to work properly.

We need to introduce a new config variable, to specify the wiki that the shortener lives on, so wikifarms like Wikimedia can have a single shortening wiki used by all other wikis.

Details

SubjectRepoBranchLines +/-
Enable UrlShortener everywhereoperations/mediawiki-configmaster+1 -2
Set permission of creating short url to everyone everywhereoperations/mediawiki-configmaster+0 -3
Drop newbie RateLimit and make user more strictmediawiki/extensions/UrlShortenermaster+3 -6
Rename the ratelimit group from user to user-globalmediawiki/extensions/UrlShortenermaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Urbanecm created this task.Nov 16 2020, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 16 2020, 1:46 PM
Urbanecm added a parent task: T267921: Roll out the Toolbox link for URL Shortener in Wikimedia sites.Nov 16 2020, 1:46 PM
Urbanecm mentioned this in T267921: Roll out the Toolbox link for URL Shortener in Wikimedia sites.Nov 16 2020, 1:52 PM
Ammarpad triaged this task as Medium priority.Dec 2 2020, 10:46 AM
Ammarpad subscribed.Dec 2 2020, 10:52 AM
Ammarpad added a comment.Dec 4 2020, 8:56 AM

Completing T229633: Convert use of $wgUrlShortenerReadOnly to urlshortener-create-url in production would simplify this

Legoktm subscribed.Aug 11 2021, 9:05 PM

In Wikimedia wikis, that variable is set to true at all wikis but metawiki, in order for throttling to work properly.

There's actually no reason we need to limit creating shorturls to just metawiki, we can make the throttling global instead by renaming the key to user-global (and probably just drop the "newbie" entry).

Ladsgroup subscribed.Aug 13 2021, 9:47 PM

Yeah, fixing the throttling (and possibly reducing it a bit) would unblock further deployment but deployment of link toolbox is blocked on design and performance review (the current design is not great)

gerritbot added a comment.Aug 28 2021, 10:32 PM

Change 715322 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/UrlShortener@master] Rename the ratelimit group from user to user-global

https://gerrit.wikimedia.org/r/715322

gerritbot added a project: Patch-For-Review.Aug 28 2021, 10:32 PM
gerritbot added a comment.Aug 28 2021, 11:16 PM

Change 715322 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@master] Rename the ratelimit group from user to user-global

https://gerrit.wikimedia.org/r/715322

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).Aug 29 2021, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 29 2021, 12:10 AM
Krinkle assigned this task to Ladsgroup.Aug 29 2021, 3:33 AM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 29 2021, 3:33 AM
gerritbot added a comment.Aug 30 2021, 12:06 PM

Change 715489 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/UrlShortener@master] Drop newbie RateLimit and make user more strict

https://gerrit.wikimedia.org/r/715489

gerritbot added a project: Patch-For-Review.Aug 30 2021, 12:06 PM
gerritbot added a comment.Aug 30 2021, 12:33 PM

Change 715492 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Set permission of creating short url to everyone everywhere

https://gerrit.wikimedia.org/r/715492

gerritbot added a comment.Aug 30 2021, 4:52 PM

Change 715489 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@master] Drop newbie RateLimit and make user more strict

https://gerrit.wikimedia.org/r/715489

gerritbot added a comment.Sep 6 2021, 2:11 PM

Change 715492 merged by jenkins-bot:

[operations/mediawiki-config@master] Set permission of creating short url to everyone everywhere

https://gerrit.wikimedia.org/r/715492

Stashbot added a comment.Sep 6 2021, 2:17 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-06T14:17:23Z] <ladsgroup@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:715492|Set permission of creating short url to everyone everywhere (T267921 T267925)]], Part I (duration: 00m 59s)

Stashbot added a comment.Sep 6 2021, 2:19 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-06T14:19:14Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:715492|Set permission of creating short url to everyone everywhere (T267921 T267925)]], Part II (duration: 00m 57s)

gerritbot added a comment.Sep 7 2021, 10:59 PM

Change 719381 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Enable UrlShortener everywhere

https://gerrit.wikimedia.org/r/719381

gerritbot added a comment.Sep 7 2021, 11:10 PM

Change 719381 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable UrlShortener everywhere

https://gerrit.wikimedia.org/r/719381

Stashbot added a comment.Sep 7 2021, 11:13 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-07T23:13:54Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:719381|Enable UrlShortener everywhere (T267925)]] (duration: 00m 58s)

Ladsgroup closed this task as Resolved.Sep 7 2021, 11:15 PM

https://en.wikipedia.org/wiki/Special:UrlShortener works

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits