Differential D195495
Bug 1864008 - Move libvpx to libgkcodecs, part 2 Authored by chunmin on Dec 4 2023, 11:37 PM.
Details
This patch addes trampoline headers for libvpx. To follow the libwebrtc merge procedure, the vpx headers are silently On the other hand, the rtc_build_libvpx is set to true in
Diff Detail
Event TimelineComment Actions The analysis task source-test-clang-tidy failed, but we could not detect any defect. The analysis task source-test-clang-external failed, but we could not detect any defect. The analysis task source-test-clang-format failed, but we could not detect any defect. If you see a problem in this automated review, please report it here. Comment Actions I'm having trouble verifying this does what is intended when built with: ac_add_options --with-system-libvpx --without-sysroot For some reason, I'm getting complaints about compiler versions on linux and other errors on macOS. However, if you've verified the proper includes are picked up in your local builds, I'm ok with this. It doesn't break the normal case builds for me locally. Comment Actions It works on my linux machine. I am testing it on try: https://treeherder.mozilla.org/jobs?repo=try&revision=3572a8e4a1214ec017c2a3231f2fa0be2936181d to see if it's green. |