Fix several type annotations for mypy 0.4.6 compatibility. #2545
Conversation
A few functions had arguments removed without having their type annotations updated accordingly. As a result mypy version 0.4.6 thinks that the first type in the annotation is supposed to be the type of `self`, a new mypy feature which we are not intending to use here.
|
Automated message from Dropbox CLA bot @rwbarton, it looks like you've already signed the Dropbox CLA. Thanks! |
|
You can also just add a commit upgrading our mypy in requirements/mypy.txt. |
|
There's another issue with |
|
Okay, I provisioned and ran mypy from inside the VM and that file does pass with mypy 0.4.5, so I can investigate what's going on here. |
|
I think that's actually a |
|
Merged, thanks @rwbarton! |
|
Okay here is the situation. There is a type error in Should I fix it with a |
|
What we usually do when working around this sort of issue is add |
A few functions had arguments removed without having their type
annotations updated accordingly. As a result mypy version 0.4.6
thinks that the first type in the annotation is supposed to be
the type of
self, a new mypy feature which we are not intendingto use here.