dependencies: Downgrade typescript to v3.4.5. #12476
Conversation
In 537014e, we upgraded typescript to v3.5.1 which causes eslint to complain that it doesn't support the newer version yet: ``` $ tools/lint tools/webpack.config.ts eslint | ============= eslint | eslint | WARNING: You are currently running a version of TypeScript which is not officially supported by typescript-estree. eslint | eslint | You may find that it works just fine, or you may not. eslint | eslint | SUPPORTED TYPESCRIPT VERSIONS: >=3.2.1 <3.5.0 eslint | eslint | YOUR TYPESCRIPT VERSION: 3.5.1 eslint | eslint | Please only submit bug reports when using the officially supported version. eslint | eslint | ============= ``` This commit upgrades to v3.4.5 instead to reverting the original commit since newer typescript verison is supported.
|
Ick, OK, downgrading. |
|
Oops, unmerged due to CI errors. |
|
ESLint’s definition of “supported TypeScript version” is “the version they test against”, but using a different one doesn’t seem like a huge deal. See https://github.com/typescript-eslint/typescript-eslint/blob/master/README.md#supported-typescript-version and typescript-eslint/typescript-eslint#184 for some context. We could turn off that warning with |
|
Turning of that warning sounds like the right solution to me. |
| @@ -46,7 +46,7 @@ | |||
| "to-markdown": "3.1.0", | |||
| "ts-loader": "5.3.3", | |||
| "ts-node": "7.0.1", | |||
| "typescript": "3.5.1", | |||
| "typescript": "3.5.0", | |||
There was a problem hiding this comment.
Yikes, Looks like I make this commit wrong. I put this version and ran yarn install and it prompted me that this version is not valid so I picked v3.4.5. I though yarn would actually update this but it didn't and I lost track this. (And provision afterwards I think ran fine for me since it was cached)
|
I created #12477 for turning off the warnings. |
In 537014e, we upgraded typescript
to v3.5.1 which causes eslint to complain that it doesn't support the
newer version yet:
This commit upgrades to v3.4.5 instead to reverting the original commit
since newer typescript version is supported.
Testing Plan:
Running
tools/lint tools/webpack.config.tseslint stops complaning about unsupported version.