This repository was archived by the owner on Jan 29, 2020. It is now read-only.
1. Fix ClassScanner::getInterfaces() which don't work with Interface. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. add TestCase ClassScannerTest::testGetInterfacesFromInterface().
|
I wouldn't bother. After much complaining, the scanner code is being formally deprecated. Look at #91 I'd recommend working with nikic/PHP-Parser instead, it's actually maintained. |
|
@djmattyg007 #91 is a suggestion by me, not something that got any approval so far. Still, for stable versions we should fix bugs anyway :-) |
Ocramius
added a commit
that referenced
this pull request
Sep 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already h
60A8
ave an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from issue #90