8000 completes hasSomething & removeSomething methods on the Classgenerator by basz · Pull Request #26 · zendframework/zend-code · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

completes hasSomething & removeSomething methods on the Classgenerator #26

Closed
wants to merge 21 commits into from
Closed

completes hasSomething & removeSomething methods on the Classgenerator #26

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3dd06ba
introduce removeProperty method
basz Dec 2, 2015
b48dbaa
add unittest
basz Dec 2, 2015
0928fb1
introduce removeConstant method
basz Jan 8, 2016
e35bf2d
add unittest
basz Jan 8, 2016
c5e0012
introduce removeExtentedClass and hasExtentedClass methods
basz Jan 8, 2016
554e98d
adds unittests
basz Jan 8, 2016
0751564
introduces hasImplementedInterface and removeImplementedInterface met…
basz Jan 8, 2016
d515195
add unittests
basz Jan 8, 2016
fb2353b
introduce hasUse, removeUse, hasUseAlias, removeUseAlias methods with…
basz Jan 12, 2016
d36400b
add unitest
basz Jan 12, 2016
ebe746f
doc block note
basz Jan 12, 2016
4a5c385
cleanup : docblock, leftover line and code styles
basz Jan 12, 2016
ed190e1
TraitUsageGenerator deprecation in 2.7. Use UsageGenerator instead
basz Jan 12, 2016
2b14fd6
prevent addUse with different alias to be stored
basz Jan 12, 2016
4db8842
Revert "TraitUsageGenerator deprecation in 2.7. Use UsageGenerator in…
basz Jan 13, 2016
09968b5
mention added methods in docs
basz Jan 13, 2016
6e7f0c6
Revert "doc block note"
basz Jan 13, 2016
3304e2c
return types
basz Jan 25, 2016
3e74da8
Can always directly unset(), no check needed
basz Jan 25, 2016
00d9fbe
I would also check against \\ strings...
basz Jan 25, 2016
801e093
cs
basz Feb 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
I would also check against \\ strings...
  • Loading branch information
@basz
basz committed Jan 25, 2016
commit 00d9fbec8d9d88a2d1d217dd77b1dbcc2dd525c2
6 changes: 6 additions & 0 deletions src/Generator/ClassGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,10 @@ public function removeExtentedClass()
*/
public function setImplementedInterfaces(array $implementedInterfaces)
{
array_map(function($implementedInterface) {
return (string) TypeGenerator::fromTypeString($implementedInterface);
}, $implementedInterfaces);

$this->implementedInterfaces = $implementedInterfaces;
return $this;
}
Expand All @@ -470,6 +474,7 @@ public function getImplementedInterfaces()
*/
public function hasImplementedInterface($implementedInterface)
{
$implementedInterface = (string) TypeGenerator::fromTypeString($implementedInterface);
return in_array($implementedInterface, $this->implementedInterfaces);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also check against \\ strings. Since you are basing against the 7.0 branch, you may want to check the type generator class

}

Expand All @@ -479,6 +484,7 @@ public function hasImplementedInterface($implementedInterface)
*/
public function removeImplementedInterface($implementedInterface)
{
$implementedInterface = (string) TypeGenerator::fromTypeString($implementedInterface);
unset($this->implementedInterfaces[array_search($implementedInterface, $this->implementedInterfaces)]);
return $this;
}
Expand Down
0