8000 Add attach/detach keybinds and allow editing attached objects directly by mharis001 · Pull Request #691 · zen-mod/ZEN · GitHub
[go: up one dir, main page]
Skip to content

Add attach/detach keybinds and allow editing attached objects directly#691

Merged
mharis001 merged 2 commits intomasterfrom
attached-objects
Dec 24, 2022
Merged

Add attach/detach keybinds and allow editing attached objects directly#691
mharis001 merged 2 commits intomasterfrom
attached-objects

Conversation

@mharis001
Copy link
Member
@mharis001 mharis001 commented Nov 15, 2022

When merged this pull request will:

  • Add "Attach Objects" and "Detach Objects" keybinds to attach/detach multiple objects at a time
  • Allow editing attached objects directly
    • Previously, attached objects would snap back to their original position when edited through Zeus
    • Now, we manually re-attach them based on their new relative position to the parent object
  • Move all attached objects handling to new attached_objects component

@mharis001 mharis001 added the feature Adds a new feature label Nov 15, 2022
@mharis001 mharis001 added this to the 1.13.0 milestone Nov 15, 2022
@Kexanone
Copy link
Member
Kexanone commented Dec 3, 2022

Any reason you chose Alt over Ctrl for the default keybind?

@mharis001
Copy link
Member Author
mharis001 commented Dec 3, 2022

Do not remember why. Would Ctrl be a better default?

@Kexanone
Copy link
Member
Kexanone commented Dec 3, 2022

I messed up before... I meant to replace Shift with Ctrl, since I find Ctrl+Alt+Key a more natural choice than Shift+Alt+Key, but it's probably more a matter of personal preference.

@mharis001 mharis001 requested a review from neilzar December 9, 2022 22:33
@mharis001
Copy link
Member Author
mharis001 commented Dec 24, 2022

Changed to CTRL + SHIFT + _. Feels like the most natural to use.

@mharis001 mharis001 merged commit 9199403 into master Dec 24, 2022
@mharis001 mharis001 deleted the attached-objects branch December 24, 2022 23:49
@Kexanone
Copy link
Member
Kexanone commented Dec 24, 2022 •
edited
Loading

Ctrl+Shift is actually even better. Anyway ppl can adjust it to whatever they want, so no big deal in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kexanone Kexanone Kexanone approved these changes

@neilzar neilzar Awaiting requested review from neilzar

Assignees

No one assigned

Labels

feature Adds a new feature

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mharis001 @Kexanone
0