8000 Add mod icons to create unit trees by mharis001 · Pull Request #684 · zen-mod/ZEN · GitHub
[go: up one dir, main page]

Skip to content

Add mod icons to create unit trees#684

Merged
mharis001 merged 3 commits intomasterfrom
mod-icons
Dec 3, 2022
Merged

Add mod icons to create unit trees#684
mharis001 merged 3 commits intomasterfrom
mod-icons

Conversation

@mharis001
Copy link
Member

When merged this pull request will:

@mharis001 mharis001 added the feature Adds a new feature label Oct 1, 2022
@mharis001 mharis001 added this to the 1.13.0 milestone Oct 1, 2022
Copy link
Member
@Kexanone Kexanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but changing the setting should trigger reloading the module tree.

@mharis001
Copy link
Member Author

ZEN is sort of split on that right now. Some settings reload the display automatically (e.g. faction filter) while others apply once the display is manually reloaded (e.g. the similar group icons setting). I guess if we change it here, the behaviour should be made consistent across all features.

@Kexanone
Copy link
Member
Kexanone commented Dec 3, 2022

ZEN is sort of split on that right now. Some settings reload the display automatically (e.g. faction filter) while others apply once the display is manually reloaded (e.g. the similar group icons setting). I guess if we change it here, the behaviour should be made consistent across all features.

Agreed, we should have a dedicated PR for that. In fact I was about to make the same comment for the placement preview, but thought it was out of scope for that PR.

@mharis001 mharis001 merged commit 791e66f into master Dec 3, 2022
@mharis001 mharis001 deleted the mod-icons branch December 3, 2022 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interface Symbol

3 participants

0