Open
Conversation
This reverts commit 3453a09.
…nto persistent-modules
Member
|
One problem with this is that the module does not have the correct name, category, or icon in the entities tree. |
Contributor
Author
|
@mharis001 well I am not going to try and implement that kind of UI hacking, so if nobody else is up for the job, you could at least let it slide undercover and not list it publicly as a official supported function. This little change however, will greatly expand custom module possibilities and I personally would not mind the incorrect information inside the entities tree. |
Member
|
The module isn't passed as a parameter to the function. Also, if the user code really needs a logic object, it can create one. Need to think more about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
PR for #577