8000 Remove Game Master module locality transfer fix timeout by mharis001 · Pull Request #487 · zen-mod/ZEN · GitHub
[go: up one dir, main page]

Skip to content

Remove Game Master module locality transfer fix timeout#487

Merged
mharis001 merged 2 commits intomasterfrom
game-master-timeout
Nov 20, 2020
Merged

Remove Game Master module locality transfer fix timeout#487
mharis001 merged 2 commits intomasterfrom
game-master-timeout

Conversation

@mharis001
Copy link
Member

When merged this pull request will:

  • title, with a very large amount of mods the module can take a long time to be unassigned when loading in initially (from testing, as much as 50 s)

@mharis001 mharis001 added the enhancement Improves an existing feature label Nov 16, 2020
@mharis001 mharis001 added this to the 1.10.0 milestone Nov 16, 2020
Copy link
Member
@CreepPork CreepPork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other alternatives, by not relying on hard-coding the timeout?

@mharis001
Copy link
Member Author

Removing it altogether. Looking at it now, don't think it is needed.

@mharis001 mharis001 changed the title Increase Game Master module locality transfer fix timeout Remove Game Master module locality transfer fix timeout Nov 16, 2020
@mharis001 mharis001 added cleanup Removes bloat from code and removed enhancement Improves an existing feature labels Nov 16, 2020
@mharis001 mharis001 requested a review from CreepPork November 16, 2020 21:19
@mharis001 mharis001 merged commit 979d8be into master Nov 20, 2020
@mharis001 mharis001 deleted the game-master-timeout branch November 20, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Removes bloat from code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0