feat: show system notification once download is complete, canceled or failed #8235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How does it look? |
Author
It uses the system notifications (OS notifications), on Linux it looks like this: I also made this PR to add translation: zen-browser/l10n-packs#153 |
Member
|
Oh, sorry! The images didnt load. |
Author
@mauro-balades I added the images after your comment, do let me know if you want any changes done! 🙏 |
Author
|
Hi @mauro-balades, I hope you're doing well! Just wanted to kindly check in on this PR. Let me know if there's anything I can clarify or improve. I’d be happy to make any adjustments if needed. Thanks for your time 🙏 |
Comment on lines
+37
to
+45
| onDownloadChanged: download => { | ||
| if (download.succeeded) { | ||
| this.#handleDownloadComplete(download); | ||
| } else if (download.canceled) { | ||
| this.#handleDownloadCanceled(download); | ||
| } else if (download.error) { | ||
| this.#handleDownloadFailed(download); | ||
| } | ||
| }, |
There was a problem hiding this comment.
maybe more cool:
if (download.succeeded) {
this.#handleDownloadComplete(download);
}
if (download.canceled) {
this.#handleDownloadCanceled(download);
}
if (download.error) {
this.#handleDownloadFailed(download);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added desktop notifications for download events.
The browser now shows a system notification when a download:
completes successfully
is canceled
fails due to error
Each notification:
Uses a localized title and message (document.l10n.formatValue)
Falls back to plain strings if localization fails
Includes the downloaded file's path
Uses the standard download.svg icon
Can be toggled via the zen.downloads.download-notifications preference
This enhancement improves user feedback and aligns with modern UX expectations for background downloads.
Translations (l10n): zen-browser/l10n-packs#153