8000 Test Azure on only one version of Python on windows. by Carreau · Pull Request #685 · zarr-developers/zarr-python · GitHub
[go: up one dir, main page]

Skip to content

Test Azure on only one version of Python on windows. #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2021

Conversation

Carreau
Copy link
Contributor
@Carreau Carreau commented Jan 1, 2021
  1. On appveyor, ABS store represent close to 25% of the test time 8min
    total, see 10 slowest tests below).
  2. Appveyor is the slowest of the CI, the one we wait for most of the
    time.
  3. ABS has not reason to behave differently on different Python
    versions.
  4. We might be able to also test windows on WSL in GH-actions.
========================== slowest 10 test durations ==========================
43.32s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_resize_2d
21.28s call     zarr/tests/test_hierarchy.py::TestGroupWithABSStore::test_getitem_contains_iterators
17.72s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_np_ufuncs
17.54s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_array_2d
14.79s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_iter
13.76s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_append_2d
13.55s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_append_2d_axis
12.01s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_array_order
11.77s call     zarr/tests/test_indexing.py::test_set_orthogonal_selection_3d
8.52s call     zarr/tests/test_storage.py::TestFSStore::test_s3_complex
==== 1808 passed, 303 skipped, 3 xpassed, 13 warnings in 333.74s (0:05:33) ====

8000
1) On appveyor, ABS store represent close to 25% of the test time  8min
total, see 10 slowest tests below).
2) Appveyor is the slowest of the CI, the one we wait for most of the
time.
3) ABS has not reason to behave differently on different Python
versions.
4) We might be able to also test windows on WSL in GH-actions.

```
========================== slowest 10 test durations ==========================
43.32s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_resize_2d
21.28s call     zarr/tests/test_hierarchy.py::TestGroupWithABSStore::test_getitem_contains_iterators
17.72s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_np_ufuncs
17.54s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_array_2d
14.79s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_iter
13.76s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_append_2d
13.55s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_append_2d_axis
12.01s call     zarr/tests/test_core.py::TestArrayWithABSStore::test_array_order
11.77s call     zarr/tests/test_indexing.py::test_set_orthogonal_selection_3d
8.52s call     zarr/tests/test_storage.py::TestFSStore::test_s3_complex
==== 1808 passed, 303 skipped, 3 xpassed, 13 warnings in 333.74s (0:05:33) ====
```
@Carreau
Copy link
Contributor Author
Carreau commented Jan 1, 2021

This works and does not decrease coverage, the test time is now down to 4min on the two lowest version of Python (3 min of which are installing package). So next step would be to speedup installing.

@Carreau Carreau merged commit 91fe437 into zarr-developers:master Jan 1, 2021
@Carreau Carreau deleted the skip-abs-appveyor branch January 1, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0