8000 WIP: Use NumPy's `fromfile` and `tofile` by jakirkham · Pull Request #494 · zarr-developers/zarr-python · GitHub
[go: up one dir, main page]

Skip to content

WIP: Use NumPy's fromfile and tofile #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

WIP: Use NumPy's fromfile and tofile #494

wants to merge 2 commits into from

Conversation

jakirkham
Copy link
Member

For reading and writing data on disk, start using NumPy's fromfile and tofile.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • Docs build locally (e.g., run tox -e docs)
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

For reading and writing data on disk, start using NumPy's `fromfile` and
`tofile`.
Instead of opening and closing files ourselves, go ahead and let NumPy
handle this when reading from and writing to disk.
@alimanfoo
Copy link
Member
alimanfoo commented Oct 29, 2019 via email

@jakirkham
Copy link
Member Author

This probably doesn't merit review ATM. It's part of some exploratory work I'm doing.

@alimanfoo
Copy link
Member
alimanfoo commented Oct 29, 2019 via email

@jakirkham
Copy link
Member Author

I think PR ( #503 ) gets at the actual need a bit cleaner. So will close this out. Thanks for humoring me 🙂

@jakirkham jakirkham closed this Nov 8, 2019
@jakirkham jakirkham deleted the use_tofile_fromfile branch November 8, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0