Fixtureize and parametrize h5py copy tests. #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: most of the beginning change is just an indent-level increase so I could put the h5 file in a context manager. |
|
@QuLogic : are you still interested in taking this forward? If so, there are a few conflicts in your test changes. |
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 99.45% 99.94% +0.48%
==========================================
Files 28 28
Lines 10287 10237 -50
==========================================
Hits 10231 10231
+ Misses 56 6 -50
|
joshmoore
approved these changes
Feb 19, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this is that closing h5py files using
atexitseems to be a bit buggy. If I run withpytest, it's fine, but if I usepython setup.py test, it will crash on exit.Using pytest fixtures, we can avoid
atexitentirely and files will be closed at the end of the test. Unfortunately, this meansunittest.TestCasecannot be used, so switch to a plain class works. With the fixture, we can parametrize zarr vs. h5py and drop the extra classes.TODO:
tox -e docs)