Test pop with default argument
#380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds another case to `test_pop` for stores generally, which merely tests if `pop` can handle the default argument correctly when no key can be found.
Some implementations of `pop` might carelessly set the `default` to `None` when not passed. However this would make it impossible to distinguish the case where the user passed `None` for the `default` intentionally versus not passing anything for the `default`. The result being both cases would raise a `KeyError`, but the error would be incorrect in the first case. The usual way of solving this is to create some dummy object and make that the `default` when if it is not set. That way one can compare if the dummy object is seen and only raise then. Thus passing `None` for the `default` would not error, but return `None` if the `key` does not exist as expected. This test is added to catch this potential oversight.
7 tasks
|
Thoughts @zarr-developers/core-devs? |
|
Merging to get these additional tests in. If there are any issues, please let me know and we can work to address them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds another case to
test_popfor stores generally, which merely tests ifpopcan handle the default argument correctly when no key can be found.TODO:
tox -e docs)