Suppress FileNotFoundError when deleting keys in the obstore adapter #3140
Conversation
|
Thanks for the PR/fix! This is slightly surprising behaviour to me - I would expect trying to delete a non-existent file to raise an error. But I guess if this is existing behaviour/design across other stores, this is good. To be sure that we're getting consistent behaviour across stores, could you move the test you added to the |
|
I think a better long-term solution would be for the stores to all raise the same exception when attempting to delete a missing key, and for the caller of the store method to handle that exception specifically in the context of attempting to remove an empty chunk. But this fix also works! |
From the obstore side I don't have total control over that. The upstream s3 implementation does not raise an error: https://docs.rs/object_store/latest/object_store/trait.ObjectStore.html#method.delete_stream |
Suppress
FileNotFoundErrorindeleteoperation of the obstore adapter.Since some underlying stores allow this, while others raise an error, supressing the error results in consistent behaviour across all stores. This also mimics how the same thing is implemented in the
fsspecadapter.Fixes #3136
TODO:
changes/